Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hostapd/wpa_supplicant: update urls #29467

Merged
merged 1 commit into from Sep 17, 2017
Merged

hostapd/wpa_supplicant: update urls #29467

merged 1 commit into from Sep 17, 2017

Conversation

mguentner
Copy link
Contributor

Motivation for this change

old urls are unreachable

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@mguentner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Krofek, @bluescreen303 and @wkennington to be potential reviewers.

@joachifm
Copy link
Contributor

Both appear to redirect to https

@mguentner
Copy link
Contributor Author

I only see a HTTP 200 OK, however the files are also available through https.

% Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0*   Trying 212.71.239.96...
* TCP_NODELAY set
* Connected to w1.fi (212.71.239.96) port 80 (#0)
> GET /releases/wpa_supplicant-2.6.tar.gz HTTP/1.1
> Host: w1.fi
> User-Agent: curl/7.55.1
> Accept: */*
>
< HTTP/1.1 200 OK
< Date: Sun, 17 Sep 2017 11:35:13 GMT
< Server: Apache/2.2.22 (Ubuntu)
< Last-Modified: Sun, 02 Oct 2016 19:29:18 GMT
< ETag: "1d3d98-2a03f4-53de6d7ed9f80"
< Accept-Ranges: bytes
< Content-Length: 2753524
< Content-Type: application/x-gzip
<
{ [1116 bytes data]
100 2688k  100 2688k    0     0  1344k      0  0:00:02  0:00:02 --:--:-- 1183k
* Connection #0 to host w1.fi left intact

@joachifm
Copy link
Contributor

(Redirects in my browser :)

It's nice to use https when it is available, seeing as you're updating the urls anyway.

@mguentner
Copy link
Contributor Author

Fair enough. I changed the urls to https.

@joachifm joachifm merged commit aa818c5 into NixOS:master Sep 17, 2017
@joachifm
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mguentner @mention-bot @joachifm