Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monero: 0.10.3.1 -> 0.11.0.0 #29464

Merged
merged 1 commit into from Sep 16, 2017
Merged

monero: 0.10.3.1 -> 0.11.0.0 #29464

merged 1 commit into from Sep 16, 2017

Conversation

mattcode55
Copy link
Contributor

Motivation for this change

After a recent hardfork in Monero, old clients are no longer compatible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@mattcode55, thanks for your PR! By analyzing the history of the files in this pull request, we identified @clefru, @ehmry and @womfoo to be potential reviewers.

@@ -30,7 +30,6 @@ stdenv.mkDerivation {
bin/monerod \
bin/monero-blockchain-export \
bin/monero-blockchain-import \
bin/monero-utils-deserialize \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to justify removing this line, monero-utils-deserialize isn't built by default after monero-project/monero@71e2876.

@joachifm
Copy link
Contributor

cc @ehmry

@ehmry ehmry self-assigned this Sep 16, 2017
@ehmry ehmry merged commit 21e135c into NixOS:master Sep 16, 2017
@mattcode55 mattcode55 deleted the bump/monero-0.11.0.0 branch September 16, 2017 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants