Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeswitch: fix build #29463

Merged
merged 1 commit into from Sep 17, 2017
Merged

freeswitch: fix build #29463

merged 1 commit into from Sep 17, 2017

Conversation

womfoo
Copy link
Member

@womfoo womfoo commented Sep 16, 2017

Motivation for this change

The latest build seems to be picking up as instead of yasmfor its assembler
Forcing it to use yasm fixes the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@womfoo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @globin and @viric to be potential reviewers.

@womfoo womfoo mentioned this pull request Sep 16, 2017
Closed
@joachifm joachifm added this to the 17.09 milestone Sep 17, 2017
@fpletz fpletz merged commit 7db2916 into NixOS:master Sep 17, 2017
@womfoo womfoo deleted the fix-build/freeswitch branch September 18, 2017 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@womfoo @mention-bot @joachifm @fpletz