Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lftp: fix build on darwin #28809

Merged
merged 1 commit into from Sep 1, 2017
Merged

lftp: fix build on darwin #28809

merged 1 commit into from Sep 1, 2017

Conversation

eqyiel
Copy link
Contributor

@eqyiel eqyiel commented Sep 1, 2017

Motivation for this change

lftp doesn't build on Darwin.

Things done

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)

  • Built on platform(s)

    • NixOS
    • macOS
    • Linux

  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Fits CONTRIBUTING.md.

  • Add gettext (which provides -lintl) to prevent failing with

ld: library not found for -lintl
clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
  • Disable format hardening to prevent failing with
/nix/store/hwx5i1w9q29m2rh8i8gs2l3yk3bpz67z-bash-4.4-p12/bin/bash ../libtool --silent  --tag=CXX   --mode=compile clang++ -DHAVE_CONFIG_H -I. -I../lib  -I../lib -I../trio   -O2 -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -c -o ProtoLog.lo ProtoLog.cc
/nix/store/hwx5i1w9q29m2rh8i8gs2l3yk3bpz67z-bash-4.4-p12/bin/bash ../libtool --silent  --tag=CXX   --mode=compile clang++ -DHAVE_CONFIG_H -I. -I../lib  -I../lib -I../trio   -O2 -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -c -o Filter.lo Filter.cc
/nix/store/hwx5i1w9q29m2rh8i8gs2l3yk3bpz67z-bash-4.4-p12/bin/bash ../libtool --silent  --tag=CXX   --mode=compile clang++ -DHAVE_CONFIG_H -I. -I../lib  -I../lib -I../trio   -O2 -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -c -o SignalHook.lo SignalHook.cc
/nix/store/hwx5i1w9q29m2rh8i8gs2l3yk3bpz67z-bash-4.4-p12/bin/bash ../libtool --silent  --tag=CXX   --mode=compile clang++ -DHAVE_CONFIG_H -I. -I../lib  -I../lib -I../trio   -O2 -Wall -Wwrite-strings -Woverloaded-virtual -fno-exceptions -fno-rtti -fno-implement-inlines -c -o FileCopy.lo FileCopy.cc
FileCopy.cc:141:12: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
         debug((9,_("copy: destination file is already complete\n")));
         ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/config.h:2010:18: note: expanded from macro '_'
                 ^
./log.h:84:59: note: expanded from macro 'debug'
                                                          ^
FileCopy.cc:141:12: note: treat the string as an argument to avoid this
         debug((9,_("copy: destination file is already complete\n")));
                  ^
                  "%s",
../lib/config.h:2010:18: note: expanded from macro '_'
                 ^
./log.h:84:59: note: expanded from macro 'debug'
                                                          ^
FileCopy.cc:182:12: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
         debug((9,_("copy: put is broken\n")));
         ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/config.h:2010:18: note: expanded from macro '_'
                 ^
./log.h:84:59: note: expanded from macro 'debug'
                                                          ^
FileCopy.cc:182:12: note: treat the string as an argument to avoid this
         debug((9,_("copy: put is broken\n")));
                  ^
                  "%s",
../lib/config.h:2010:18: note: expanded from macro '_'
                 ^
./log.h:84:59: note: expanded from macro 'debug'
                                                          ^
FileCopy.cc:251:18: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
               debug((9,_("copy: all data received, but get rolled back\n")));
               ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../lib/config.h:2010:18: note: expanded from macro '_'
                 ^
./log.h:84:59: note: expanded from macro 'debug'
                                                          ^
FileCopy.cc:251:18: note: treat the string as an argument to avoid this
               debug((9,_("copy: all data received, but get rolled back\n")));
                        ^
                        "%s",
../lib/config.h:2010:18: note: expanded from macro '_'
                 ^
./log.h:84:59: note: expanded from macro 'debug'
                                                          ^
3 errors generated.
make[2]: *** [Makefile:2264: FileCopy.lo] Error 1
make[2]: Leaving directory '/private/var/folders/jt/qgrx8lp10ylbdlnb93t54r6c0000gn/T/nix-build-lftp-4.8.0.drv-3/lftp-4.8.0/src'
make[1]: *** [Makefile:1669: all-recursive] Error 1
make[1]: Leaving directory '/private/var/folders/jt/qgrx8lp10ylbdlnb93t54r6c0000gn/T/nix-build-lftp-4.8.0.drv-3/lftp-4.8.0'
make: *** [Makefile:1614: all] Error 2
note: keeping build directory ‘/private/var/folders/jt/qgrx8lp10ylbdlnb93t54r6c0000gn/T/nix-build-lftp-4.8.0.drv-3’
builder for ‘/nix/store/94d2rwf1yylm2i9xl634ismkqks5bsg2-lftp-4.8.0.drv’ failed with exit code 2
error: build of ‘/nix/store/94d2rwf1yylm2i9xl634ismkqks5bsg2-lftp-4.8.0.drv’ failed
nix-build -A lftp -I nixpkgs=. --keep-failed  48.30s user 20.00s system 68% cpu 1:39.76 total

@mention-bot
Copy link

@eqyiel, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @vbgl and @c0bw3b to be potential reviewers.

@eqyiel
lftp: fix build on darwin
d908b6a 
Add `gettext` (which provides `-lintl`) and disable `format` hardening in order
to fix build.
@eqyiel
Copy link
Contributor Author

eqyiel commented Sep 1, 2017

Whoops, I just amended the commit message to be not so verbose.

@Mic92 Mic92 merged commit 4c99d55 into NixOS:master Sep 1, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 1, 2017

Thanks!

@eqyiel eqyiel deleted the fix-lftp branch November 3, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eqyiel @mention-bot @Mic92