Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ssl, sqlite and crystax library loads on Android versions before ~4.4 #1106

Merged
merged 4 commits into from Sep 23, 2017

Conversation

inclement
Copy link
Member

This PR rebases and restructures #903.

I've tested this only in the emulator, but I was able to reproduce the original issue, and this rebased PR seems to fix everything.

Fixes #866.

@KeyWeeUsr
Copy link
Contributor

What about listing the libDir and fetching all .so files? It'd solve this issue even for other recipes. Also, is there a possibility that the NDK would generate versioned libs? If yes, then the approach will probably fail: libmy.so.1.

@rnixx
Copy link
Member

rnixx commented Sep 1, 2017

@KeyWeeUsr There have been complaints about auto loading all libs here #903 (comment)

@rnixx
Copy link
Member

rnixx commented Sep 1, 2017

Nevertheless. It would be great if there was a way to explicitly define libs to be loaded in the specs file or so.

@inclement
Copy link
Member Author

inclement commented Sep 1, 2017

@KeyWeeUsr I thought about that, and I don't actually agree with @akshayaurora's objection (it seems to me that anyone who can place .so files for automatic loading can probably also just modify an existing one), but went for the extra explicit option instead. Automatic loading would also have the problem that we'd still need to impose some ordering on what is loaded when, so it wouldn't be possible to be completely naive about it.

I'm thinking to add a Recipe attribute that specifies .so files which will be produced, then to try to load them according to the recipe build order. I guess this will normally be correct. But, if this works, I think it's mergeable as it is to fix the issue for now.

@inclement inclement added this to the 0.6 milestone Sep 1, 2017
@inclement inclement merged commit 4727b1c into kivy:master Sep 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Couldn't load python3.5m: findLibrary returned null" on older versions of Android
4 participants