Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages.live-server : init at 1.2.0 #28813

Closed
wants to merge 2 commits into from

Conversation

wizzup
Copy link
Contributor

@wizzup wizzup commented Sep 1, 2017

Motivation for this change

To add live-server A simple development http server with live reload capability.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

$ nix-shell -I nixpkgs=/nix/nixpkgs -p nodePackages.live-server --run 'live-server --version'
live-server 1.2.0

@Mic92 Mic92 closed this in 86587ea Sep 1, 2017
@@ -73,7 +73,7 @@ let
version = "3.0.4";
src = fetchurl {
url = "https://registry.npmjs.org/minimatch/-/minimatch-3.0.4.tgz";
sha512 = "1879a3j85h92ypvb7lpv1dqpcxl49rqnbgs5la18zmj1yqhwl60c2m74254wbr5pp3znckqpkg9dvjyrz6hfz8b9vag5a3j910db4f8";
sha1 = "5166e286457f03306064be5497e8dbb0c3d32083";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new version of node2nix now uses the more secure sha512. I rerun the script to solve the merge conflict.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I didn't have path to this repo in my $NIX_PATH, that is the reason why generate.sh use node2nix version 1.2.0

@wizzup wizzup deleted the add/nodePackages.live-server branch September 2, 2017 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants