-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How about Porting the Contents of org.jruby.bench
to JMH?
#4752
Comments
personally, wanted to have JMH available as a test dependency a few times already :) |
@kares nice :)
Exactly! This would make demonstrating/evaluating improvements much easier :) That said, let's do it! (this should be fairly quick and trivial:)) Where should we put the Maven module for this? Just top level |
not sure if we would need a new 'module' ... maybe some of the existing places can be (re-)used :
JRuby usually uses pom.rb but that shouldn't matter a raw pom.xml will be just fine, since it will be an isolated module anyway. might be some build tricks needed to keep it up-to-date - could be solved later. |
@kares let's do
This is how I set it up for Logstash https://github.com/elastic/logstash/tree/master/logstash-core/benchmarks and I think we could do the same by putting some |
First step towards JMH benchmarks as discussed in #4752
@kares port the other two benchmarks in that package to JMH as well? :) |
@original-brownbear if you're into that I do not see why not ... should be useful as an inspiration at least |
There are some pure Java micro-benchmarks in
org.jruby.bench
, that simply usepublic static void main(
invocation and don't seem to have any clean warmup logic and such.I would suggest to maybe port those to JMH cleanly and once done would also be very happy to contribute further benchmark cases.
I have quite a few performance spots in Logstash I'm working on right now that I'd love to optimize by contributions to JRuby and having JMH as a tool available would be great for speeding this kind of work up.
I'll probably create some JMH code around JRuby, but if there's interest in a PR I'll do a cleaner job => just let me know if you think it's something you'd like to have :)
The text was updated successfully, but these errors were encountered: