Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcxx-stdenv: fix for darwin #29034

Closed
wants to merge 1 commit into from
Closed

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Sep 5, 2017

Motivation for this change

Building something with llvmPackages.libcxxStdenv on darwin fails.

In file included from /nix/store/lm7bpsys535kxfljlkpw23l9k3rvbsgl-cxx-main.cc:1:
In file included from /nix/store/0hfqkfzq503hhxmh0rqjaym23pyhlfcn-libc++-4.0.1/include/c++/v1/iostream:38:
In file included from /nix/store/0hfqkfzq503hhxmh0rqjaym23pyhlfcn-libc++-4.0.1/include/c++/v1/ios:215:
In file included from /nix/store/0hfqkfzq503hhxmh0rqjaym23pyhlfcn-libc++-4.0.1/include/c++/v1/iosfwd:90:
/nix/store/0hfqkfzq503hhxmh0rqjaym23pyhlfcn-libc++-4.0.1/include/c++/v1/wchar.h:133:77: error: use of undeclared identifier 'wcschr'
wchar_t* __libcpp_wcschr(const wchar_t* __s, wchar_t __c) {return (wchar_t*)wcschr(__s, __c);}
                                                                            ^
...
/nix/store/0hfqkfzq503hhxmh0rqjaym23pyhlfcn-libc++-4.0.1/include/c++/v1/string.h:78:13: note: candidate disabled: <no message provided>
      char* strchr(      char* __s, int __c) {return __libcpp_strchr(__s, __c);}
            ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added 6.topic: darwin Running or building packages on Darwin 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 5, 2017
@LnL7
Copy link
Member Author

LnL7 commented Sep 13, 2017

Included in #29246

@LnL7 LnL7 closed this Sep 13, 2017
@LnL7 LnL7 deleted the darwin-libcxx-stdenv branch September 13, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 9.needs: port to stable A PR needs a backport to the stable release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant