Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amarok: fixup by building with gcc-5 #29043

Merged
merged 1 commit into from Sep 7, 2017
Merged

amarok: fixup by building with gcc-5 #29043

merged 1 commit into from Sep 7, 2017

Conversation

jerith666
Copy link
Contributor

due to continued lack of progress on
#16588, probably not worth the
time for anything better.

Progress on: #28643

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jerith666
amarok: fixup by building with gcc-5
af57251 
due to continued lack of progress on
NixOS#16588, probably not worth the
time for anything better.

Progress on: NixOS#28643
@joachifm joachifm merged commit f66ed30 into NixOS:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jerith666 @joachifm