Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulseaudio: 10.0 -> 11.0 #29041

Closed
wants to merge 1 commit into from
Closed

pulseaudio: 10.0 -> 11.0 #29041

wants to merge 1 commit into from

Conversation

MP2E
Copy link

@MP2E MP2E commented Sep 5, 2017

Remove darwin patch that has been included in the upstream release, tested on my desktop with a variety of programs. Nox review has not been run yet but I plan on it

Motivation for this change

All sorts of fixes and new hardware support! Check out the changelog here:

https://www.freedesktop.org/wiki/Software/PulseAudio/Notes/11.0/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

remove darwin patch that has been included in this upstream release
@mention-bot
Copy link

@MP2E, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @edolstra and @lovek323 to be potential reviewers.

@Mic92
Copy link
Member

Mic92 commented Sep 5, 2017

you probably want to wait with nox-review until the mass rebuild for nixpkgs went through.

@MP2E
Copy link
Author

MP2E commented Sep 8, 2017

Travis failures were due to build timeouts, nox-review seemed to pass but I had to make some unrelated changes to the PR to get it to evaluate, will work on getting those changes cleaned + upstreamed

Merged as of dc3f0d4

@MP2E MP2E closed this Sep 8, 2017
@MP2E MP2E deleted the pulse_update branch September 8, 2017 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants