Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spin: 6.4.6 -> 6.4.7 #29262

Merged
merged 1 commit into from Sep 12, 2017
Merged

spin: 6.4.6 -> 6.4.7 #29262

merged 1 commit into from Sep 12, 2017

Conversation

sifmelcara
Copy link
Member

@sifmelcara sifmelcara commented Sep 12, 2017 •
edited

Motivation for this change

Update the package.

cc maintainer @pSub

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@sifmelcara, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pSub and @abbradar to be potential reviewers.

@sifmelcara
Copy link
Member Author

I'm not very sure if spinroot.com still have DDoS protection that blocks curl. However, I can successfully build this package on my computer, so maybe they do not block curl anymore?

@Mic92 Mic92 merged commit e9040c5 into NixOS:master Sep 12, 2017
@orivej
Copy link
Contributor

orivej commented Sep 12, 2017 •
edited

HTTP response headers of e.g. http://spinroot.com/spin/Src/ contain Server: cloudflare-nginx and Cf-Ray: 39d665b9543542b5-OSL, so it is served by CloudFlare. Certainly they do not block curl because it's curl, but they occasionally replace real content with a captcha page (especially when requesting IP address is associated with automatic high volume activity), and this blocks curl.

@sifmelcara
Copy link
Member Author

@orivej thank you for pointing that out.
To be honest, after some research I still have no idea how to get the dropbox raw download link... If someone know how to get the correct link, please tell me or make another commit to fix the url. I would be very thankful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sifmelcara @mention-bot @orivej @Mic92