Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.audiotools: Fix darwin build #29253

Merged
merged 1 commit into from Sep 12, 2017
Merged

pythonPackages.audiotools: Fix darwin build #29253

merged 1 commit into from Sep 12, 2017

Conversation

knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented Sep 11, 2017 •
edited

Motivation for this change

Fix pythonPackages.audiotools as part of #29221

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added 6.topic: darwin Running or building packages on Darwin 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 12, 2017
@LnL7 LnL7 force-pushed the fix-pythonPackages.audiotools branch from 6320632 to 6d760d9 Compare September 12, 2017 17:53
@LnL7
Copy link
Member

LnL7 commented Sep 12, 2017

Reenabled the darwin build since it was marked as linux only.

@LnL7 LnL7 merged commit cd286d4 into NixOS:master Sep 12, 2017
@LnL7 LnL7 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 12, 2017
@knedlsepp
Copy link
Member Author

Thx! :-) That's what I get for allowBroken. :-/

@knedlsepp knedlsepp deleted the fix-pythonPackages.audiotools branch September 12, 2017 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knedlsepp @LnL7