Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gitolite: add RequiresMountsFor unit option #29247

Merged
merged 1 commit into from Sep 12, 2017
Merged

nixos/gitolite: add RequiresMountsFor unit option #29247

merged 1 commit into from Sep 12, 2017

Conversation

pvgoran
Copy link
Contributor

@pvgoran pvgoran commented Sep 11, 2017 •
edited

Needed to ensure that the filesystem where dataDir resides is mounted when we do initialization or upgrade.

Motivation for this change

Resolution for #29195.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pvgoran
services.gitolite: Add RequiresMountsFor unit option ...
4c4f73c 
... to ensure that the filesystem where `dataDir` resides is mounted when we do initialization or upgrade.
@Mic92 Mic92 merged commit ebc1127 into NixOS:master Sep 12, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 12, 2017

Thanks!

@Mic92
Copy link
Member

Mic92 commented Sep 12, 2017

Also fixed in 17.09.

@Mic92
Copy link
Member

Mic92 commented Sep 12, 2017

Also fixed in 17.03.

@pvgoran pvgoran deleted the gitolite-RequiresMountsFor branch September 12, 2017 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pvgoran @Mic92 @Janik-Haag