Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gringo: add darwin platform support #29251

Merged
merged 1 commit into from Sep 12, 2017
Merged

gringo: add darwin platform support #29251

merged 1 commit into from Sep 12, 2017

Conversation

winniequinn
Copy link
Contributor

Motivation for this change

Adding Darwin support for gringo will allow aspcud to build for Darwin as well. This is important beause aspcud is the recommended dependency solver for OPAM, the OCaml package manager, and currently opam specifically avoids using aspcud on Darwin (as per this discussion).

If this PR is merged, I will follow up with PRs for aspcud and opam to get everything working on Darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Sep 12, 2017
@vbgl vbgl merged commit a101328 into NixOS:master Sep 12, 2017
@winniequinn winniequinn deleted the gringo-darwin branch September 23, 2017 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants