Altcoins: remove obsolete override, update some altcoins #29248
Conversation
|
@Lassulus, thanks for your PR! By analyzing the history of the files in this pull request, we identified @AndersonTorres, @mcmtroffaes and @abbradar to be potential reviewers. |
Lassulus
changed the title
|
Regarding namecoin: I was just about to open a PR for the update: infinisil@8bd3664 Edit: force pushed with some of your changes incorporated I'm gonna comment on the differences |
| cp namecoin-qt $out/bin | ||
| ''; | ||
| configureFlags = [ "--with-boost-libdir=${boost.out}/lib" ] | ||
| ++ optionals withGui [ "--with-gui=qt4" ]; |
There was a problem hiding this comment.
--with-gui=qt4 is not needed, it gets detected automatically
| nativeBuildInputs = [ pkgconfig autoreconfHook ]; | ||
| buildInputs = [ openssl db4 boost libtool libuuid | ||
| protobuf libevent ] | ||
| ++ optionals withGui [ qt4 ]; |
There was a problem hiding this comment.
db4 and protobuf are only needed for the GUI
There are also some other different dependencies between our versions.
There was a problem hiding this comment.
Sorry, db4 is needed in any case, but there is the optional libqrencode dependency
| meta = namecoind.meta; | ||
| meta = { | ||
| description = "Decentralized open source information registration and transfer system based on the Bitcoin cryptocurrency"; | ||
| homepage = http://namecoin.info; |
|
@infinisil thanks for the comments, I'm gonna test them and update the PR accordingly. |
This updates namecoin from a legacy version from about 3 years ago (https://github.com/namecoin/namecoin-legacy) to the new namecoin-core. (cherry picked from commit 8bd3664)
|
@infinisil I cherry-picked your commit. If you make any new updates just give me a message :) |
|
Thanks :) |
Motivation for this change
remove the obsolete override in all-packages.nix.
fix broken altcoins.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)