Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-stdenv: move libstdcxxHook to cc-wrapper #29246

Merged
merged 3 commits into from Sep 13, 2017
Merged

clang-stdenv: move libstdcxxHook to cc-wrapper #29246

merged 3 commits into from Sep 13, 2017

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Sep 11, 2017

Motivation for this change

Fixes #29204

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more nixpkgs test(s) (tests.cc-wrapper)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 11, 2017
Ericson2314
Ericson2314 reviewed Sep 11, 2017
View reviewed changes
pkgs/development/compilers/llvm/3.7/default.nix

libcxxClang = ccWrapperFun {
cc = self.clang-unwrapped;
isClang = true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because it figures it out automatically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's not necessary.

Ericson2314
Ericson2314 approved these changes Sep 11, 2017
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ericson2314 Ericson2314 merged commit 349a092 into NixOS:master Sep 13, 2017
@LnL7 LnL7 mentioned this pull request Sep 13, 2017
Closed
8 tasks
@LnL7 LnL7 added the 8.has: port to stable A PR already has a backport to the stable release. label Sep 13, 2017
@LnL7 LnL7 mentioned this pull request Oct 22, 2017
Closed
@LnL7 LnL7 deleted the clang-stdenv branch October 22, 2017 10:26
@corngood
Copy link
Contributor

I bisected a problem I'm having in one of my local environments to this commit.

$ nix-shell -p gcc -p clang --command 'echo "int main() { return 0; }" | c++ -x c++ -'
g++: error: unrecognized command line option ‘-stdlib=libstdc++’; did you mean ‘-static-libstdc++’?

I only just started looking into it, but I thought I'd check if anyone had any thoughts. I'm creating an environment with gcc for building, and clang for tooling.

@LnL7
Copy link
Member Author

LnL7 commented Oct 24, 2017

@corngood See #29877 for discussion on that problem.

@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

llvmPackages_39.stdenv cannot find libstdc++
4 participants
@LnL7 @corngood @Ericson2314 @samueldr