Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommNet Antenna changes #1773

Merged
merged 2 commits into from
Jan 24, 2018
Merged

CommNet Antenna changes #1773

merged 2 commits into from
Jan 24, 2018

Conversation

smartdummies
Copy link
Contributor

Changes to RN IS/Soviet proes, FASA antennas, Squad antennas, AIES
antennas, Coatl antennas, and BlackLeg antennas

Changes to RN IS/Soviet proes, FASA antennas, Squad antennas, AIES
antennas, Coatl antennas, and BlackLeg antennas
@raidernick
Copy link
Contributor

raidernick commented Sep 12, 2017

This needs to be redone. Every single one of my parts that has an antenna has a NEEDS[Remotetech] pass after the realism overhaul config pass. You made all the changes in the regular config instead of the remotetech config right under that. This is going to cause problems. If you can't put it in the RT pass it still needs to be in it's own pass that will run before the RT one but after the RO configs and won't conflict if RT is installed.

I don't want anyone to merge this until that is fixed.

@smartdummies
Copy link
Contributor Author

@raidernick The changes for is for for stock CommNet and not for RT which is why I placed these in the initial pass. The antenna change for your parts follows other places such that the first pass updates the stock ModuleDataTransmitter module and then an NEEDS[RemoteTech] config removes the stock module and configures the ModuleRTAntenna module. If this is not correct then I can move my changes into a NEEDS[!RemoteTech] section. Let me know how this should be handled an I will make my changes accordingly

@raidernick
Copy link
Contributor

I would prefer they be in their own pass yes they should not be in the main pass

@smartdummies
Copy link
Contributor Author

I will make it so

Placing the CommNet updates in a :NEEDS[!RemoteTech] section
@smartdummies
Copy link
Contributor Author

@raidernick check out these confgs and if they are correct I will apply these changes to the other files.

@smartdummies
Copy link
Contributor Author

Can somebody take a look at these and let me know if the changes are good so I can go on and apply the same style to the remaining file.

Thanks

@NathanKell
Copy link
Member

LGTM.

@NathanKell NathanKell merged commit 0293eac into KSP-RO:dev Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants