Just an entirely offtopic comment: I don't think forwarding argument using *args, **options is a good pattern because it makes the documentation suck. Perhaps we should try to remove this all over the stdlib?

@RX14 I don't agree, I think that forwarding arguments is good, what needs a fix is the documentation generation.
Maybe the crystal doc could detect the arguments forwarding? Or we could add a mention about it in the docs, like :arg_forwarding: gets, to mark the method as forwarding its arguments to all versions of gets, and allow crystal doc to generate the proper documentation?

@RX14 I also agree with you regarding the ugly docs, but gets has several overloads.

Thanks!

@jhass Please note that you seem to be the only one who creates merge commits when merging pull requests. Maybe worth switching to the squash/rebase kind of merge in the UI, just for consistency's sake.

Oh sorry, I didn't notice we switched to that here, will make sure in the future. Personally I like the merge commit for a pull request though, as it keeps an easy reference to it.

@jhass Github's UI will usually show the PR a commit arrived in regardless of how it was merged. If you click on the commit it shows the PR number to the right of the current branch on the left hand side.

Yes, if you're on Github, which is not always the case ☺