-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to bigint 32bit #4922
Fixes to bigint 32bit #4922
Conversation
Could you explain briefly what were the issues before this PR? |
@bew GMP arithmetics highly depends on LibGMP built with 32bit Long/ULong on 32bit machines, otherwise 64bit (for now). So we must take in care it's |
@akzhan Is there a spec that was failing in 32 bits? I ask because these changes, without accompanying specs, seem like they aren't doing anything. |
@asterite Just tested
Will add this spec to this branch. |
It seems like you're changing |
@akzhan Awesome! Thank you :-) |
LGTM 👍 |
Please remove the changelog until we decide #4936. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge it after you remove the changelog bit.
5c93033
to
b58b046
Compare
Done ( and squashed into two logical parts). |
b58b046
to
f1dafab
Compare
Just another selection of 32bit fixes from #4675 with additions.