Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmake: init at 1.2.0 #28904

Merged
merged 4 commits into from Sep 5, 2017
Merged

mmake: init at 1.2.0 #28904

merged 4 commits into from Sep 5, 2017

Conversation

gabesoft
Copy link
Contributor

@gabesoft gabesoft commented Sep 2, 2017

Motivation for this change

Added the mmake package

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Sep 2, 2017

This should be build from source.

@gabesoft
Copy link
Contributor Author

gabesoft commented Sep 2, 2017

@FRidh I was trying to build from source but I didn't get it to work. I guess I'm kind of unfamiliar with setting up the build step for go packages. Do you have any suggestions on how I can do this (an example package would help)

@gabesoft
Copy link
Contributor Author

gabesoft commented Sep 3, 2017

@FRidh I finally figured it out. I've updated the package to build from sources.

@Mic92 Mic92 changed the title Package for mmake mmake: init at 1.2.0 Sep 3, 2017
homepage = https://github.com/tj/mmake;
description = "Mmake is a small program which wraps make to provide additional functionality, such as user-friendly help output, remote includes, and eventually more. It otherwise acts as a pass-through to standard make.";
license = licenses.mit;
platforms = platforms.all;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to maintain this package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I added myself to maintainers.

@Mic92 Mic92 merged commit 7c08e86 into NixOS:master Sep 5, 2017
fpletz pushed a commit that referenced this pull request Sep 5, 2017
* Package for mmake

* Package for mmake - build from sources

* Package name update

* Added maintainers

(cherry picked from commit 7c08e86)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants