rawtherapee: 5.0-r1 -> 5.2 #28920
Closed
rawtherapee: 5.0-r1 -> 5.2 #28920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Sep 3, 2017
| @@ -22,6 +22,8 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| cmakeFlags = [ | |||
| "-DPROC_TARGET_NUMBER=2" | |||
| "-DCACHE_NAME_SUFFIX=\"\"" | |||
| "-DCMAKE_BUILD_TYPE=\"release\"" | |||
There was a problem hiding this comment.
release is the default build type: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/build-managers/cmake/setup-hook.sh#L52
There was a problem hiding this comment.
Will fix it this evening, thanks!
markus1189
force-pushed
the
rawtherapee-5.2
branch
from
ce54c43
to
893f733
Compare
|
Fixed! |
|
Works well for me. Rebased into master in 572361f. Thanks for the contribution! |
|
I also cherry-picked to 17.09 in 58ed8fa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to the latest version of rawtherapee
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)Also added some flags found in http://rawpedia.rawtherapee.com/Linux#Compile_RawTherapee