matterbridge, modules/matterbridge: init at 1.1.0 #28892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachifm
reviewed
Sep 9, 2017
nixos/modules/misc/ids.nix
Outdated
| @@ -297,6 +297,7 @@ | |||
| clickhouse = 278; | |||
| rslsync = 279; | |||
| minio = 280; | |||
| matterbridge = 281; | |||
There was a problem hiding this comment.
Why is a dynamic uid insufficient?
ryantm
force-pushed
the
matterbridge2
branch
from
78af183
to
afe321d
Compare
|
@joachifm You're right; I think I just need the user to exist not be a particular constant ID. |
ryantm
force-pushed
the
matterbridge2
branch
from
afe321d
to
9c786d8
Compare
|
Thank you. Note that, ideally, package additions and module additions should be in separate commits. |
|
@ryantm the package expression appears to be broken: https://hydra.nixos.org/build/61154969 |
|
I have built it successfully a few days ago, but then I've collected garbage. @ryantm, if you still have an archive that hashes to the old hash, it would be interesting to see. |
|
@orivej It looks like it is some issue with the file meta data being different: I'll make a PR to fix the matterbridge. Ryan |
ryantm
added a commit
to ryantm/nixpkgs
that referenced
this pull request
Sep 18, 2017
I used the wrong source hash because of some kind of metadata problem. See NixOS#28892 (comment) for details.
fpletz
pushed a commit
that referenced
this pull request
Sep 18, 2017
I used the wrong source hash because of some kind of metadata problem. See #28892 (comment) for details.
fpletz
pushed a commit
that referenced
this pull request
Sep 19, 2017
I used the wrong source hash because of some kind of metadata problem. See #28892 (comment) for details. (cherry picked from commit 20f9493)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the matterbridge service to nixos and nixpkgs https://github.com/42wim/matterbridge