smoltcp-rs · Sep 1, 2017 · Sep 3, 2017
Showing with 22 additions and 14 deletions.

+19 −12 README.md

+3 −0 src/iface/ethernet.rs

+0 −2 src/wire/ipv4.rs
diff --git a/README.md b/README.md
@@ -31,39 +31,46 @@ The only supported medium is Ethernet.
 
 The only supported internetworking protocol is IPv4.
 
-  * IPv4 header checksum is supported.
+  * IPv4 header checksum is generated and validated.
+  * IPv4 time-to-live value is fixed at 64.
   * IPv4 fragmentation is **not** supported.
-  * IPv4 options are **not** supported.
+  * IPv4 options are **not** supported and are silently ignored.
   * IPv4 routes or default gateways are **not** supported.
   * ICMPv4 header checksum is supported.
   * ICMPv4 echo requests and replies are supported.
-  * ICMPv4 destination unreachable message is supported.
-  * ICMPv4 parameter problem message is **not** supported.
+  * ICMPv4 protocol unreachable messages are **not** passed to higher layers when received.
+  * ICMPv4 time exceeded messages are **not** supported.
+  * ICMPv4 parameter problem messages are **not** supported.
 
 ### UDP layer
 
 The UDP protocol is supported over IPv4.
 
-  * UDP header checksum is supported.
-  * UDP sockets are supported.
+  * UDP header checksum is always generated and validated.
+  * In response to a packet arriving at a port without a listening socket,
+    an ICMP destination unreachable message is generated.
 
 ### TCP layer
 
 The TCP protocol is supported over IPv4. Server and client sockets are supported.
 
-  * TCP header checksum is supported.
+  * TCP header checksum is generated and validated.
+  * Maximum segment size is negotiated.
   * Multiple packets will be transmitted without waiting for an acknowledgement.
   * Lost packets will be retransmitted with exponential backoff, starting at
     a fixed delay of 100 ms.
   * After arriving at the TIME-WAIT state, sockets will close after a fixed delay of 10 s.
   * TCP urgent pointer is **not** supported; any urgent octets will be received alongside
     data octets.
   * Reassembly of out-of-order segments is **not** supported.
-  * The status of TCP options or extensions is:
-    * Maximum segment size option is supported.
-    * Window scaling is **not** supported, and the maximum buffer size is 65536.
-    * Timestamping is **not** supported.
-    * Fast open is **not** supported when smoltcp initiates connection.
+  * Silly window syndrome avoidance is **not** supported for either transmission or reception.
+  * Congestion control is **not** implemented.
+  * Delayed acknowledgements are **not** implemented.
+  * Nagle's algorithm is **not** implemented.
+  * Window scaling is **not** supported, and the maximum buffer size is 65536.
+  * Timestamping (used in round-trip time measurement and protection against wrapped sequences)
+    is **not** supported.
+  * Fast open is **not** supported when smoltcp initiates connection.
   * Keepalive is **not** supported.
 
 ## Installation

diff --git a/src/iface/ethernet.rs b/src/iface/ethernet.rs
@@ -1,3 +1,6 @@
+// Heads up! Before working on this file you should read the parts
+// of RFC 1122 that discuss Ethernet, ARP and IP.
+
 use managed::{Managed, ManagedSlice};
 
 use {Error, Result};

diff --git a/src/wire/ipv4.rs b/src/wire/ipv4.rs
@@ -403,8 +403,6 @@ impl Repr {
         if packet.version() != 4 { return Err(Error::Malformed) }
         // Valid checksum is expected.
         if !packet.verify_checksum() { return Err(Error::Checksum) }
-        // We do not support any IP options.
-        if packet.header_len() > 20 { return Err(Error::Unrecognized) }
         // We do not support fragmentation.
         if packet.more_frags() || packet.frag_offset() != 0 { return Err(Error::Fragmented) }
         // Total length may not be less than header length.