secretstorage init at version 2.3.1 #28916
Conversation
| propagatedBuildInputs = [ dbus-python cryptography ]; | ||
| doCheck = false; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
Did you want to add yourself as maintainer?
There was a problem hiding this comment.
not really. I am not proficient with nixos nor I am knowledgeable about dbus/keyring stuff. If it's mandatory, I can put myself as a best effort thing.
There was a problem hiding this comment.
I think it is mandatory, but maybe someone else will want to be a maintainer. However, it shouldn't be too hard to be a maintainer, it should mainly just be about updating the revision and sha256 whenever there's a new release, and checking to see if it builds/works.
| src = pkgs.fetchFromGitHub { | ||
| owner = "mitya57"; | ||
| repo = "secretstorage"; | ||
| rev = "2636a47b45aff51a21dfaf1cbd9f1f3c1347f7f4"; |
There was a problem hiding this comment.
This should just be "${version}". And note the sha256 will therefore also change.
| sha256 = "1sjd2jjbxgkkxyrfwx89x0hsnn39w2cr2qkxbg1iz52znr4sqism"; | ||
| }; | ||
|
|
||
| postPatch = "patchShebangs ."; |
There was a problem hiding this comment.
this is a leftover from the derivation I took inspiration from. It should not be necessary.
|
Thank you. Added it to #29009. |
Motivation for this change
A program I use (i3pystatus) has modules depending on this python module (via the keyring python module).
https://pypi.python.org/pypi/SecretStorage
I've tested it through:
nix-shell -p python36Packages.keyring -p python36Packages.secretstorage -I ~/nixpkgs --command "keyring set gmail password"This is my first PR to nixpkgs so this might need more work. I'll try to look into the sandboxing thing.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)