Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninitialized constant in Fiddle::Pointer.malloc #3462

Closed
gdelugre opened this issue Nov 15, 2015 · 3 comments · Fixed by #4511
Closed

Uninitialized constant in Fiddle::Pointer.malloc #3462

gdelugre opened this issue Nov 15, 2015 · 3 comments · Fixed by #4511
Milestone
JRuby 9.2.0.0

Comments

@gdelugre
Copy link

When allocating memory with Fiddle on JRuby 9.0.3.0, a NameError exception is raised because the LibC module is not defined.

jruby-9.0.3.0 :001 > require 'fiddle'
 => true 
jruby-9.0.3.0 :002 > Fiddle::Pointer.malloc 16
NameError: uninitialized constant Fiddle::Pointer::LibC
    from org/jruby/RubyModule.java:3181:in `const_missing'
    from /home/user/.rvm/rubies/jruby-9.0.3.0/lib/ruby/stdlib/fiddle/jruby.rb:168:in `malloc'
    from (irb):2:in `<eval>'
    from org/jruby/RubyKernel.java:978:in `eval'
    from org/jruby/RubyKernel.java:1291:in `loop'
    from org/jruby/RubyKernel.java:1098:in `catch'
    from org/jruby/RubyKernel.java:1098:in `catch'
    from /home/user/.rvm/rubies/jruby-9.0.3.0/bin/irb:13:in `<top>'

The related code in stdlib/fiddle/jruby.rb:

    def self.malloc(size, free = nil)
      self.new(LibC.malloc(size), size, free ? free : LibC::FREE)
    end
@chrisseaton
Copy link
Contributor

There are other parts of Fiddle missing, for example Fiddle::Handle::DEFAULT and Fiddle::CParser::TYPE_SIZE_T (which importer tries to use for size_t).

@danini-the-panini danini-the-panini mentioned this issue Feb 26, 2017
Merged
@enebo enebo modified the milestones: JRuby 9.1.8.0, JRuby 9.2.0.0 Mar 6, 2017
@enebo
Copy link
Member

enebo commented Mar 6, 2017

Original PR was reverted to reopening

@enebo enebo reopened this Mar 6, 2017
@headius
Copy link
Member

headius commented May 16, 2018

I fixed this one issue for 9.2 Any additional issues should be file separately.

@ahorek ahorek mentioned this issue Nov 7, 2019
Merged
headius added a commit that referenced this issue Jan 7, 2020
@headius
Re-apply fix from #3462 and restored in jruby/ruby#2.
d4571dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
JRuby 9.2.0.0
Development

Successfully merging a pull request may close this issue.

Fix some issues with Fiddle danini-the-panini/jruby
4 participants
@headius @enebo @chrisseaton @gdelugre