Check HTTP status of minifying tools

getnikola · Nov 19, 2015 · 36f5e4d · 36f5e4d
1 parent dbb28e9
commit 36f5e4d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -9,6 +9,7 @@ Features
 Bugfixes
 --------
 
+* Check HTTP response status of minifying tools and skip them if they’re unavailable
 * Change rewrite rule for fragment-only links (Issue #2132)
 * Mention disabled plugins in ``nikola plugin --list-installed`` (Issue #2139)
 * Don't examine all gallery image dates every build (Issue #2160)

diff --git a/nikola/filters.py b/nikola/filters.py
@@ -290,6 +290,9 @@ def cssminify(data):
         url = 'http://cssminifier.com/raw'
         _data = {'input': data}
         response = requests.post(url, data=_data)
+        if response.status_code != 200:
+            LOGGER.error("can't use cssminifier.com: HTTP status {}", response.status_code)
+            return data
         return response.text
     except Exception as exc:
         LOGGER.error("can't use cssminifier.com: {}", exc)
@@ -303,6 +306,9 @@ def jsminify(data):
         url = 'http://javascript-minifier.com/raw'
         _data = {'input': data}
         response = requests.post(url, data=_data)
+        if response.status_code != 200:
+            LOGGER.error("can't use javascript-minifier.com: HTTP status {}", response.status_code)
+            return data
         return response.text
     except Exception as exc:
         LOGGER.error("can't use javascript-minifier.com: {}", exc)