x3270: init at 3.4ga9 #11080
Closed
x3270: init at 3.4ga9 #11080
+52
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| patches = [ ./repair-interpreter.patch ]; | ||
|
|
||
| meta = { |
x3270 is an IBM 3270 terminal emulator for the X Window System. It comes with some other - related - tools, such as a ncurses version or a version intended for use with scripts. These tools are currently unconditionally built, this is a possible point of improvement. Also the man pages unfortunately don't install with this nix expression. Version 3.4ga9 is the current (23. Oct 2015) stable version of this software.
musteresel
force-pushed
the
x3270-init
branch
from
59d4113 to
2cc70c6
Compare
|
@pSub I added the licence as well as corrected the description. I amended the "main commit" with these changes. The homepage of the tool does provide source tarballs of the current stable release. I thought that using the tag from the repository would be the more stable approach, but I added another commit using fetchurl and this tarball instead. Though I cannot test it locally on my machine atm. |
musteresel
force-pushed
the
x3270-init
branch
from
73001fc to
9ac5184
Compare
musteresel
force-pushed
the
x3270-init
branch
from
9ac5184 to
2d79062
Compare
|
@musteresel It seems your latest commit (2d79062) didn't work: https://travis-ci.org/NixOS/nixpkgs/builds/91654817. Also, the commit description should ideally include the package it changes. |
cillianderoiste
added
8.has: package (new)
|
(triage) @musteresel do you expect to work on this futher? |
|
Closing. Can re-open if you would like :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a nix expression to build the x3270 IBM 3270 terminal emulator, to be found there:
http://x3270.bgp.nu/index.html
I packaged the current stable version (3.4ga9 stable (23. October 2015), according to their downloads page). Though I pull the source code from the git repository instead of the provided tar balls. A small patch to fix the interpreter of an utility bash script was needed.
Actually this package now provides multiple binaries. One could add support to only build a subset of these binaries (and thus removing tcl, x dependencies). Also there are no man pages, because the respective install target fails and I don't have the time to investigate further.
As for testing I'm successfully running the applications on my laptop (NixOS on x86_64), using them to participate in the IBM Master the Mainframe contest. No further testing than this was done, though.
Please let me know if there's something that needs to be changed (this is my first to be contributed package). This is a second pull request, the first #11031 targeted the release branch and I couldn't get it to target the master branch.