Skip to content

Commit

Permalink
[Truffle] Fix encoding for core strings.
Browse files Browse the repository at this point in the history
@chrisseaton
chrisseaton committed Feb 20, 2016
1 parent 0a47709 commit 8cb49b7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions truffle/src/main/java/org/jruby/truffle/core/string/CoreString.java
View file
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
import com.oracle.truffle.api.CompilerDirectives;
import com.oracle.truffle.api.CompilerDirectives.CompilationFinal;
import com.oracle.truffle.api.object.DynamicObject;
import org.jcodings.specific.USASCIIEncoding;
import org.jcodings.specific.ASCIIEncoding;
import org.jruby.truffle.RubyContext;
import org.jruby.truffle.core.rope.CodeRange;
import org.jruby.truffle.core.rope.Rope;
@@ -50,7 +50,7 @@ private Rope createRope() {

return context.getRopeTable().getRope(
literal.getBytes(StandardCharsets.US_ASCII),
USASCIIEncoding.INSTANCE,
ASCIIEncoding.INSTANCE,
CodeRange.CR_7BIT);
}

1 comment on commit 8cb49b7

@nirvdrum
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine for the one String you're currently handling ("nil"). We'll just need to keep an eye on this as we fill in additional Strings. In most cases, they won't be ASCII-8BIT.

Sorry, something went wrong.

Please sign in to comment.