Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes to PDL::Fit::LM #176

Merged
merged 4 commits into from Feb 27, 2016
Merged

Some changes to PDL::Fit::LM #176

merged 4 commits into from Feb 27, 2016

Conversation

d-lamb
Copy link
Member

@d-lamb d-lamb commented Feb 22, 2016

Mostly it is just documentation changes. However, the new t/lm.t contains sample data copied from Gnuplot, which could potentially raise a license issue. Check that file please.

Mostly this clarifies the usage of the 'sig' argument to lmfit.
'sig' was short for 'sigma', I have changed the former to the latter.
Confusion sowed because in the example the variable was called
$wt ("weight"), when in reality the weights turn out to be 1/(sigma**2).

I added a small test suite in t/lm.t.  This uses the data 'silver.dat'
from Gnuplot, which I believe to be compatible with PDL's license.
@mohawk2
Copy link
Member

mohawk2 commented Feb 27, 2016

Since one option for Perl is to use under the GPL, I don't foresee a problem. If anyone ever complains, then we can revisit.

@wchristian wchristian merged commit 212fe50 into master Feb 27, 2016
@wchristian wchristian deleted the lmfit branch February 27, 2016 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants