[Truffle] Add Rails app integration test #3691
Merged
+3,262
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -671,7 +671,7 @@ private Object classEvalSource(DynamicObject module, DynamicObject code, String | |||
|
|
|||
| CompilerDirectives.transferToInterpreter(); | |||
| // TODO (pitr 15-Oct-2015): fix this ugly hack, required for AS | |||
| final String space = new String(new char[line-1]).replace("\0", "\n"); | |||
| final String space = new String(new char[Integer.max(line - 1, 0)]).replace("\0", "\n"); | |||
There was a problem hiding this comment.
I think this needs to be Math.max on Java 7 - that's why Travis has failed.
There was a problem hiding this comment.
Yeah, it has to, I was just looking at Travis.
|
I guess the commented out code is because this is from a Rails generated template app? Great work, Petr. |
|
yes, I think all comments in rails directory are from the rails generator. |
|
Great work on the compatibility everyone! It worked almost out of the box :) |
| @@ -42,6 +43,11 @@ public PackNode(RubyContext context) { | |||
| this.context = context; | |||
| } | |||
|
|
|||
| @CompilerDirectives.TruffleBoundary | |||
| public static Encoding getAscii() { | |||
| return Encoding.load("ASCII"); | |||
pitr-ch
force-pushed
the
rails
branch
2 times, most recently
from
440c444 to
d4e1243
Compare
| @@ -128,6 +128,10 @@ public void printBacktrace(RubyContext context, DynamicObject exception, Backtra | |||
| private String formatInLine(List<Activation> activations, DynamicObject exception) { | |||
| final StringBuilder builder = new StringBuilder(); | |||
|
|
|||
| if (activations.size() == 0) { | |||
| throw new UnsupportedOperationException(); | |||
There was a problem hiding this comment.
Please use the message field to explain why it's unsupported.
|
Looks great! |
pitr-ch
force-pushed
the
rails
branch
4 times, most recently
from
9f2a71b to
1d4c8c0
Compare
pitr-ch
pushed a commit
that referenced
this pull request
Mar 1, 2016
[Truffle] Add Rails app integration test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jruby/truffle