Skip to content

Commit

Permalink
Add jruby.home to this java invocation.
Browse files Browse the repository at this point in the history
@headius
headius committed Feb 23, 2016

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: CEF2BBFE18BD0E67
Learn about vigilant mode
1 parent 83747b9 commit 3806de1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/jruby/test_load_compiled_ruby_class_from_classpath.rb
View file
Original file line number Diff line number Diff line change
@@ -85,7 +85,7 @@ def test_loading_compiled_ruby_class_from_jar
remove_ruby_source_files

java = ENV['JAVA_HOME'] ? "#{ENV['JAVA_HOME']}/bin/java" : "java"
java_cmd = "#{java} -jar -Djruby.aot.loadClasses=true #{JarFile}"
java_cmd = "#{java} -Djruby.home=#{ENV_JAVA['jruby.home']} -jar -Djruby.aot.loadClasses=true #{JarFile}"
puts java_cmd if $VERBOSE; result = `#{java_cmd}`
assert_equal 0, $?.exitstatus, "did not get 0 for exit status from running java against the jar"
assert_equal "hello from runner", result, "wrong text from runner"

3 comments on commit 3806de1

@kares
Copy link
Member

@kares kares commented on 3806de1 Feb 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used to work without -Djruby.home or did it not? wondered if its not a regression as it came up in IT tests
// cc @mkristian

@mkristian
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kares looking through the test. it runs using lib/jruby.jar and with this you need to set jruby.home.
not sure whether the test did actually run - maybe not due to:

jruby/test/jruby/test_load_compiled_ruby_class_from_classpath.rb

Line 24 in 3806de1

if java.lang.System.getProperty("basedir") # FIXME: disabling this test under maven

but the change is legit :)

Sorry, something went wrong.

@kares
Copy link
Member

@kares kares commented on 3806de1 Feb 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks. The IT failures got me confused...

Sorry, something went wrong.

Please sign in to comment.