Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: eb3d106ab84a
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 79d923e34c9d
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Mar 3, 2016

  1. Copy the full SHA
    b5e0310 View commit details
  2. Copy the full SHA
    9fa185b View commit details
  3. Copy the full SHA
    79d923e View commit details
Showing with 4 additions and 3 deletions.
  1. +2 −2 core/src/main/java/org/jruby/ext/tempfile/Tempfile.java
  2. +1 −0 test/externals/ruby1.8/logger/test_logger.rb
  3. +1 −1 test/externals/ruby1.9/ruby/test_env.rb
4 changes: 2 additions & 2 deletions core/src/main/java/org/jruby/ext/tempfile/Tempfile.java
Original file line number Diff line number Diff line change
@@ -130,10 +130,10 @@ public IRubyObject call(ThreadContext context, IRubyObject[] args, Block block)
}

try {
File tmp = new File(tmpname.convertToString().toString());
path = tmpname.convertToString().toString();
File tmp = new File(path);
if (tmp.createNewFile()) {
tmpFile = tmp;
path = tmp.getPath();
initializeOpen(ioOptions);
} else {
throw context.runtime.newErrnoEEXISTError(path);
1 change: 1 addition & 0 deletions test/externals/ruby1.8/logger/test_logger.rb
Original file line number Diff line number Diff line change
@@ -50,6 +50,7 @@ def log_raw(logger, msg_id, *arg, &block)
logdev.open
msg = logdev.read
logdev.close
msg.gsub!(/\r\n/, "\n") # tempfile writes with crlf logic on...fix for tests
msg
end

2 changes: 1 addition & 1 deletion test/externals/ruby1.9/ruby/test_env.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require 'test/unit'

class TestEnv < Test::Unit::TestCase
IGNORE_CASE = /bccwin|mswin|mingw/ =~ RUBY_PLATFORM
IGNORE_CASE = RbConfig::CONFIG['host_os'] =~ /bccwin|mswin|mingw/
PATH_ENV = "PATH"

def setup