By analyzing the blame information on this pull request, we identified @edolstra, @joachifm and @offlinehacker to be potential reviewers

Feel free to add Cc: @aszlig - nitpick in future PRs if you want even more nitpicking (I could nitpick at even more here as well, for example on the missing commit message , but I'll stop now), the whitespace thing was just because it immediately sprang into my eyes :-D

Cc: @edolstra because of the addition of a new function in lib/attrsets.nix.

I renamed the functions to setAttrInSetByPath and updateAttrByPath @edolstra.

I also added tests and fixed errors with certain inputs for the set function (gah, dynamically typed languages ;) ).

i would like to use isso on nixos, so i tested this PR:

https://github.com/davidak/nixos-config/blob/d1fcef16470c567245fcb480c55f980b59bfc208/binary/configuration.nix#L129

it got installed, configuration got created and the service started, but with errors.

Traceback (most recent call last):
  File "/nix/store/iihfxv3fi5i2z8arsr8b1kgp2q399x6f-python2.7-isso-0.9.10/bin/.isso-wrapped", line 12, in <module>
    sys.exit(main())
  File "/nix/store/iihfxv3fi5i2z8arsr8b1kgp2q399x6f-python2.7-isso-0.9.10/lib/python2.7/site-packages/isso/__init__.py", line 271, in main
    wsgi.SocketHTTPServer(sock, make_app(conf)).serve_forever()
  File "/nix/store/iihfxv3fi5i2z8arsr8b1kgp2q399x6f-python2.7-isso-0.9.10/lib/python2.7/site-packages/isso/wsgi.py", line 203, in __init__
    HTTPServer.__init__(self, sock, SocketWSGIRequestHandler)
  File "/nix/store/awbf3jh262m1k16hxgbgngdmxv66gd79-python-2.7.11/lib/python2.7/SocketServer.py", line 420, in __init__
    self.server_bind()
  File "/nix/store/awbf3jh262m1k16hxgbgngdmxv66gd79-python-2.7.11/lib/python2.7/BaseHTTPServer.py", line 110, in server_bind
    self.server_name = socket.getfqdn(host)
  File "/nix/store/awbf3jh262m1k16hxgbgngdmxv66gd79-python-2.7.11/lib/python2.7/socket.py", line 141, in getfqdn
    hostname, aliases, ipaddrs = gethostbyaddr(name)
TypeError: must be string without null bytes, not str

that might be related to #1248 but it also don't work with a workaround.

@davidak Does this work when you put it into a container, like so:

containers.isso.config = ./isso-test.nix;

and then start it like

sudo systemctl restart container@isso
sudo journalctl -M isso

@Profpatsch yes.

(only some Umlauts are broken in issos interface)

After a restart are the comments gone, also every second restart fails.

[root@binary:~]# systemctl status container@isso.service
● container@isso.service - Container 'isso'
   Loaded: loaded (/nix/store/wssay3nkwsbqw7vr5w4dhgh9bldhzy23-unit-container-.service/container@.service; bad; vendor preset: enabled)
   Active: inactive (dead)

Jul 17 16:55:42 binary systemd[1]: container@isso.service: Main process exited, code=exited, status=1/FAILURE
Jul 17 16:55:42 binary container isso[16360]: cat: /run/containers/isso.pid: No such file or directory
Jul 17 16:55:42 binary systemd[1]: container@isso.service: Control process exited, code=exited status=1
Jul 17 16:55:42 binary systemd[1]: Failed to start Container 'isso'.
Jul 17 16:55:42 binary systemd[1]: container@isso.service: Unit entered failed state.
Jul 17 16:55:42 binary systemd[1]: container@isso.service: Failed with result 'exit-code'.
Jul 17 16:55:42 binary systemd[1]: container@isso.service: Service hold-off time over, scheduling restart.
Jul 17 16:55:42 binary systemd[1]: Stopped Container 'isso'.
Jul 17 16:55:42 binary systemd[1]: container@isso.service: Start request repeated too quickly.
Jul 17 16:55:42 binary systemd[1]: Failed to start Container 'isso'.

The Umlauts are fine when i use it in Nikola, maybe an encoding problem in your simple example website.

Your config works also without the container and then the comments are persistent and every restart works!

The difference of our configs is:

your working config:

      otherConfig = {
        server.listen = "http://localhost:9001";
      };

my try:

otherConfig = { server = { listen = "localhost:9090"; }; };

the error was the missing http://!

please change that in the example of the module:
Example: { general = { log-file = "/var/lib/isso/isso.log"; } ; server = { listen = "localhost:8080"; } ; }

my whole config: davidak/nixos-config@c8b6443

After a restart are the comments gone, also every second restart fails.

The example page doesn’t specify an encoding, as you can see in the code

please change that in the example of the module:
Example: { general = { log-file = "/var/lib/isso/isso.log"; } ; server = { listen = "localhost:8080"; } ; }

Hm, interesting. I used http:// in the test as well. But it shouldn’t be necessary imo.

But it shouldn’t be necessary imo.

have you tested it?

then resolve the merge conflicts and get it merged.

next step would be to use a WSGI Server like gunicorn for production use. the developer's choice is uWSGI but the debian package uses gunicorn. it is simpler to configure and has also a good performance. should be good most users.

https://posativ.org/isso/docs/extras/deployment/
https://github.com/jgraichen/debian-isso/blob/master/debian/isso.service
https://sicherheitskritisch.de/2015/04/sichere-installation-und-konfiguration-des-kommentarsystems-isso-auf-debian/

then resolve the merge conflicts and get it merged.

All in due time. It’s a work in progress, after all. Except if you’d like to help me. There’s a few tests to be written. :)

@Profpatsch How could i help? I haven't written module tests by now and don't know what you have in mind. So it might be more effective when you do that. Do you think you find some time in the near future?

I haven't written module tests by now and don't know what you have in mind.

I haven’t either. :)
What I want are some automatic VM tests that check if the service works from a very high level. As in checking the actual output of a test website, by posting a comment and then grepping the site output for the content of that comment. That way the maintainer is immediately notified if the service breaks.

Do you think you find some time in the near future?

This Saturday/Sunday at the earliest.

The merge conflicts are only because the gid/pid needs to be adjusted btw.

• general.dbpath don't get added into the config, the database don't get created, all comments are lost after restarting the service
• import created /tmp/isso.db but the service don't loads it
• general.notify also don't land in the config
• the current version of Isso is 0.10.4, this is 0.9.10
• there is a newline after each config line:

[general]
host = davidak.binary.lan.davidak.de
 davidak.de


[guard]
direct-reply = 3

enabled = true

ratelimit = 2

reply-to-self = false

I guess this has stalled.

Yeah, it’s pretty low on my priority list right now.

@Profpatsch sadly i had also no time to look into this. i have planned to deploy my new website without comments first next month (what is tomorrow :)). so i can make progress and fix small things like that later.

I actually planned on using isso as commenting server for audio files (soundcloud-like), but that’s a very far-off project right now.