Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit ddac6ed

Browse files
committedFeb 19, 2016
tools/flterm.py: another cleanup pass
1 parent 0e44624 commit ddac6ed

File tree

1 file changed

+9
-17
lines changed

1 file changed

+9
-17
lines changed
 

‎misoc/tools/flterm.py

+9-17
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ def __init__(self, serial_boot, kernel_image, kernel_address):
116116
self.reader_alive = False
117117
self.writer_alive = False
118118

119-
self.promp_detect_buffer = bytes(len(sfl_prompt_req))
119+
self.prompt_detect_buffer = bytes(len(sfl_prompt_req))
120120
self.magic_detect_buffer = bytes(len(sfl_magic_req))
121121

122122
def open(self, port, baudrate):
@@ -182,8 +182,8 @@ def boot(self):
182182

183183
def detect_prompt(self, data):
184184
if len(data):
185-
self.promp_detect_buffer = self.promp_detect_buffer[1:] + data
186-
return self.promp_detect_buffer == sfl_prompt_req
185+
self.prompt_detect_buffer = self.prompt_detect_buffer[1:] + data
186+
return self.prompt_detect_buffer == sfl_prompt_req
187187
else:
188188
return False
189189

@@ -213,11 +213,7 @@ def reader(self):
213213
if c == b"\r":
214214
sys.stdout.write(b"\n")
215215
else:
216-
try:
217-
# TODO: cleanup
218-
sys.stdout.write(c.decode())
219-
except:
220-
pass
216+
sys.stdout.buffer.write(c)
221217
sys.stdout.flush()
222218

223219
if self.kernel_image is not None:
@@ -243,10 +239,7 @@ def stop_reader(self):
243239
def writer(self):
244240
try:
245241
while self.writer_alive:
246-
try:
247-
b = getkey()
248-
except KeyboardInterrupt:
249-
b = b"\x03"
242+
b = getkey()
250243
if b == b"\x03":
251244
self.stop()
252245
elif b == b"\n":
@@ -296,13 +289,12 @@ def _get_args():
296289
def main():
297290
args = _get_args()
298291
flterm = Flterm(args.serial_boot, args.kernel, args.kernel_adr)
299-
flterm.open(args.port, args.speed)
300-
flterm.start()
301292
try:
293+
flterm.open(args.port, args.speed)
294+
flterm.start()
302295
flterm.join(True)
303-
except KeyboardInterrupt:
304-
pass
305-
flterm.close()
296+
finally:
297+
flterm.close()
306298

307299

308300
if __name__ == "__main__":

0 commit comments

Comments
 (0)