do/while looks a little better

mojolicious · Mar 3, 2016 · f00cf2c · f00cf2c
1 parent 02d7ebf
commit f00cf2c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/lib/Mojo/IOLoop.pm b/lib/Mojo/IOLoop.pm
@@ -152,10 +152,10 @@ sub timer { shift->_timer(timer => @_) }
 
 sub _id {
   my $self = shift;
-  while (my $id = md5_sum 'c' . steady_time . rand) {
-    next if $self->{in}{$id} || $self->{out}{$id} || $self->{acceptors}{$id};
-    return $id;
-  }
+  my $id;
+  do { $id = md5_sum 'c' . steady_time . rand }
+    while $self->{in}{$id} || $self->{out}{$id} || $self->{acceptors}{$id};
+  return $id;
 }
 
 sub _in { scalar keys %{shift->{in} || {}} }

diff --git a/lib/Mojo/Reactor/Poll.pm b/lib/Mojo/Reactor/Poll.pm
@@ -116,9 +116,9 @@ sub watch {
 
 sub _id {
   my $self = shift;
-  while (my $id = md5_sum 't' . steady_time . rand) {
-    return $id unless $self->{timers}{$id};
-  }
+  my $id;
+  do { $id = md5_sum 't' . steady_time . rand } while $self->{timers}{$id};
+  return $id;
 }
 
 sub _next {