Protect self and CompiledCode from GC before handling arguments #3626
+19
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When arguments are keywords, `GenericArguments::call` will call `Rubinius::Runtime.keyword_object?`, which results in allocating some objects. When the young zone is full, garbage collection is run, which could lead to forwarding the self and/or the CompiledCode objects without updating their references, resulting in a faulty behavior or crashes like in rubinius#3540. Fixes rubinius#3540
|
@ahmadsherif thanks for looking into this. The situation you identified is a big problem across many parts of the codebase and is the reason I started on the work in the stw branch. That branch makes all allocation paths GC-safe (ie the GC will never run during allocation), among other things. Since this is only one of several issues and I'm really close to merging stw, I'd like to hold off on these changes. |
|
@brixen No problem, thanks you for clarifying 😃 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When arguments are keywords,
GenericArguments::callwill callRubinius::Runtime.keyword_object?, which results in allocating some objects. When the young zone is full, garbage collection is run, which could lead to forwarding the self and/or the CompiledCode objects without updating their references, resulting in a faulty behavior or crashes like in #3540.However, I'm not sure about the solution, so a feedback would be appreciated 😃 .