Protect self and CompiledCode from GC before handling arguments #3626
+19
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When arguments are keywords,
GenericArguments::call
will callRubinius::Runtime.keyword_object?
, which results in allocating some objects. When the young zone is full, garbage collection is run, which could lead to forwarding the self and/or the CompiledCode objects without updating their references, resulting in a faulty behavior or crashes like in #3540.However, I'm not sure about the solution, so a feedback would be appreciated 😃 .