[5.2] In the Unique validation rule, allow ignoring an id using an array key #12612
Conversation
|
How does it hit the database for every key? Doesn't ->getValue only return a single value? |
|
@taylorotwell I meant the check for uniqueness, It'll do the check for every record in the array. So in this example, for every person record the |
|
Hmm, I wonder if that could be a problem. For example if a malicious user sends 5,000 e-mails into the route, etc. |
|
Yeah if 5,000 records were sent, the Validator will run I guess we need to collect all Something like: public function getCountForArray($collection, $column, array $values, $idColumn = null, array $extra = [])
{
$query = $this->table($collection);
$idColumn = $idColumn ?: 'id';
$firstValue = array_first($values);
$query->where(function ($q) use ($column, $idColumn, $values, $firstValue) {
foreach ($values as $value) {
$whereMethod = $value == $firstValue ? 'where' : 'orWhere';
$q->$whereMethod([
[$column, '=', $value[$column]],
[$idColumn, '<>', $value['exclude']],
]);
}
});
foreach ($extra as $key => $extraValue) {
$this->addWhere($query, $key, $extraValue);
}
$query->select($column, $idColumn);
$results = array_pluck($query->get(), $column);
$output = [];
foreach ($values as $value) {
$output[$value[$column]] = in_array($value[$column], $results);
}
return $output;
}And then in the validator we call the presence verifier method only once at the beginning, and inside Not sure if that's the best way to do it, this also will require much changes in the validator. What do you think? |
As mentioned in this issue #12607.
While validating a value is unique inside an array of values there's currently no way to ignore a specific id for every record in the array.
This PR will allow the following:
Notes
[array_key]to be able to separate between a value and a key.PresenceVerifierfor now.