Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clean up the entire spec temp dir when finished with mock dirs.
The mock dirs are created with mkdir_p, so they'll create the spec temp dir if it doesn't already exist. However, it does so after changing the umask to 0, which affects the permissions on the spec temp dir. The spec temp dir is normally not recreated if it already exists, so these atypical permissions persist after any test using the mock dirs is finished. The safest thing to do is delete the entire spec temp dir, since the next spec requiring it will cause it to be recreated, but this time with the corrected umask.
789e2b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eregon Please verify that this is fine to do. All specs pass for me and I can't find a case where it would break anything.
789e2b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nirvdrum Would not changing the umask also fix it?