Clean up the entire spec temp dir when finished with mock dirs.

The mock dirs are created with mkdir_p, so they'll create the spec temp dir if it doesn't already exist. However, it does so after changing the umask to 0, which affects the permissions on the spec temp dir. The spec temp dir is normally not recreated if it already exists, so these atypical permissions persist after any test using the mock dirs is finished. The safest thing to do is delete the entire spec temp dir, since the next spec requiring it will cause it to be recreated, but this time with the corrected umask.
jruby · Feb 29, 2016 · 789e2b1 · 789e2b1 · nirvdrum · Feb 29, 2016
1 parent 6cc96c1
commit 789e2b1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/spec/ruby/core/dir/fixtures/common.rb b/spec/ruby/core/dir/fixtures/common.rb
@@ -112,7 +112,7 @@ def self.create_mock_dirs
   end
 
   def self.delete_mock_dirs
-    rm_r mock_dir
+    rm_r SPEC_TEMP_DIR
   end
 
   def self.mock_rmdir(*dirs)