Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not include Enumerable directly #3699

Merged
merged 1 commit into from Dec 15, 2016
Merged

Not include Enumerable directly #3699

merged 1 commit into from Dec 15, 2016

Conversation

makenowjust
Copy link
Contributor

You said "This is fixed in 0.19.0".

@makenowjust
Copy link
Contributor Author

fixed in 06f386d

@Sija
Copy link
Contributor

Sija commented Dec 15, 2016

@makenowjust There are still 2 instances left: in Tuple and BitArray.

@makenowjust
Copy link
Contributor Author

@Sija wow. reopen and fixes it.

@makenowjust makenowjust reopened this Dec 15, 2016
@makenowjust makenowjust force-pushed the fix/indexable/enumerable-todo branch 2 times, most recently from bb0dd35 to a7120f5 Compare December 15, 2016 13:57
@makenowjust makenowjust changed the title Avoid TODO, not to include Enumeranle directly Not to include Enumerable directly Dec 15, 2016
@makenowjust makenowjust changed the title Not to include Enumerable directly Not include Enumerable directly Dec 15, 2016
@makenowjust
Not include Enumerable directly
3270204 
because Indexable includes Enumerable
@asterite
Copy link
Member

Good catch, thank you!

@asterite asterite merged commit 0172980 into crystal-lang:master Dec 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@makenowjust @Sija @asterite