Remove dot segments in uri path as per RFC 3986 6.2.2.3 #3697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this causes a couple failures in other places. Maybe I should not touch |
|
I don't think the original URI from the given string should be changed. In any case, I'd add a |
taylorfinnell
force-pushed
the
remove-dot-segments-in-uri-path
branch
from
38d5acb
to
6f90a63
Compare
|
@asterite I added the normalize method, I agree I think it is the better way! |
|
@taylorfinnell Thank you! I think this addition is good. If others can review and approve this too, I'll merge it. |
|
Excellent! Let me know if there is anything I can do! Hoping this is merged for 0.2.2 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per 3986 6.2.2 URI paths should be normalized. This adds part of the normalization process and handles relative paths (6.2.2.3). ie
/example/..would be/.Another option would be to add a
normalized_pathmethod.Let me know what you think :)