Forcing webassets to really rebuild files. #2596
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've experiencing a problem with assets bundling: if I create a bundle out of CSS files which are all generated by a plugin, the following happens:
nikola build
first, none of the CSS files are there when generating thecreate_bundles
task, whence an empty file is written;create_bundles
task is executed after executing the tasks which write the CSS files;nikola build
a second time, nikola sees the CSS files and executes thecreates_bundles
task another time;So the result is an empty (unchanged) CSS bundle file, even though the input files changed (they are not empty), which is clearly wrong.
From the webassets source, I extracted a way to force it to rebuild the bundles. If that doesn't work in some cases, we could also simply delete the output file before asking it to rebuild; that should have the same result.