New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement String#lchomp #3701

Merged

asterite merged 1 commit into crystal-lang:master from Sija:string-lchomp

Dec 15, 2016

Contributor

Sija commented Dec 15, 2016 •

edited

This PR adds String#lchomp method which removes given String | Char from the beginning of the string.

It's quite handy method, many times requested to be included in Ruby's stdlib.
See for instance https://www.reddit.com/r/ruby/comments/19khox/cmon_ruby_we_need_stringlchomp/

Other solutions to this issue are way less optimal:

"hello".reverse.chomp("hel".reverse).reverse
"hello".starts_with?("hel") ? "hello"["hel".size..-1] : "hello"
"hello".sub(/\Ahel/, "")


          Implement String#lchomp

c321f22

Member

asterite commented Dec 15, 2016

I like it, thank you! I think it's symmetry with chomp makes it a good thing to have in the standard library.

asterite added kind:feature topic:stdlib labels

asterite added this to the 0.20.2 milestone

asterite merged commit 60bf3cd into crystal-lang:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment