use better content types for source requests

If the API source endpoint is accessed directly, rather than through st.aticpan.org, provide a more reasonable content type. Images are given a the appropriate type for the file, text files are served as text/plain, and everything else is octet-stream.
metacpan · Dec 20, 2016 · 7c23a0c · 7c23a0c
1 parent 128339e
commit 7c23a0c
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/lib/MetaCPAN/Server/Controller/Source.pm b/lib/MetaCPAN/Server/Controller/Source.pm
@@ -40,9 +40,19 @@ sub get : Chained('index') : PathPart('') : Args {
         $c->stash->{path} = $file;
 
         # Add X-Content-Type header, for fastly to rewrite on st.aticpan.org
-        $c->res->header( 'X-Content-Type' => Plack::MIME->mime_type($file)
-                || 'text/plain' );
-        $c->res->content_type('text/plain');
+        my $type = Plack::MIME->mime_type($file) || 'text/plain';
+        $c->res->header( 'X-Content-Type' => $type );
+        if ( $type =~ m{^image/} ) {
+            $c->res->content_type($type);
+        }
+        elsif ( $type
+            =~ m{^(?:text/.*|application/javascript|application/json)$} )
+        {
+            $c->res->content_type('text/plain');
+        }
+        else {
+            $c->res->content_type('application/octet-stream');
+        }
         $c->res->body( $file->openr );
     }
 }