There was another problem in _postprocess_path which only showed up when allowing page numbers for Atom feeds, so I decided to simply fix both things.

The last commit shows how this actually can simplify things. (And it is a test case that the whole thing actually works.)

The last commit (00acea8) isn't completely good. In case the setting INDEXES_PRETTY_PAGE_URL evaluates to True, it doesn't work correctly since it ignores the argument force_addition. That's in fact the only place where force_addition == True, and the argument is only ever needed for page_path and not for page_link.

How about keeping the new code, but only in page_path make a special case which handles force_addition == True? This avoids repeating more logic from the path handlers in the TaxonomiesClassifier plugin, but makes the functions seem more complex.

(“make it work” should be the top priority, not “make it look good”)

Well, before the commit it worked well, so reverting the commit is a simple solution. On the other hand, I also like to avoid writing logic twice, and using Nikola.link and Nikola.path for the common situation (i.e. when force_addition == False) does that, even though it doesn't look so great. It's kind of a style question.

I guess undoing the commit is the simplest solution which makes it work, though.

I decided to undo the commit. (I also fixed an unrelated typo.)

Oh, another idea: how to add an additional argument to the path handler (like alternative_path), and then use that?

@ralsina, any review?

Thanks!