Darwin closed-source apps: init Steam, Spotify #20670

matthewbauer · 2016-11-24T00:46:15Z

Motivation for this change

This inits derivations for spotify and steam on Darwin. undmg needs to be updated to set the executable bits correctly.

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

mention-bot · 2016-11-24T00:46:25Z

@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mpscholten to be a potential reviewer.

LnL7 · 2016-11-24T07:48:45Z

pkgs/applications/audio/spotify/darwin.nix

+  name = "spotify-mac";
+
+  src = fetchurl {
+    url = "http://download.spotify.com/Spotify.dmg";


I assume there's no versioned url we can use, it would be nice if we could provide a source that will keep working.

I haven't found a versioned release yet.

Yeah, that's going to be hard for applications like that in general.

I have pulled older versions from here: http://filehippo.com/mac/download_spotify_for_mac/
But I am not sure whether we want to trust a third-party site...

This is what they link to on the website (but with a versioned file)
https://d1clcicqv97n4s.cloudfront.net/Spotify-1.0.42.151.g19de0aa6.dmg

LnL7 · 2016-11-24T07:49:02Z

pkgs/top-level/all-packages.nix

-    libgcrypt = libgcrypt_1_5;
-    libpng = libpng12;
-  };
+  spotify_mac = callPackage ../applications/audio/spotify/darwin.nix {};


Should we perhaps put them in a darwin.applications attrset, might be easier if everything is in one place.

The thing is most of these have equivalent linux derivations that you should have the same name.

shouldn't it pick the correct derivation based on the platform.

To clarify, I was talking about the spotify_mac attribute here.

matthewbauer · 2016-11-25T00:29:31Z

I'm thinking of just starting a "nixpkgs-app" repo. It will be to nixpkgs what cask is to homebrew.

mpscholten · 2016-11-25T09:34:52Z

What would be the advantage of this? Keeping everything in the main nixpkgs keeps things simpler IMO.

ghost · 2016-12-01T10:08:28Z

pkgs/games/steam/darwin.nix

+    homepage = http://store.steampowered.com/;
+    license = licenses.unfreeRedistributable;
+    platforms = platforms.darwin;
+    maintainers = with maintainers; [ jagajaga ];


Are you sure that @jagajaga has an interest in maintaining Steam for Darwin platform?

woops, I'll get rid of that.

ghost · 2016-12-01T10:25:59Z

@mpscholten IMO this will lead to nixpkgs repo bloat, so separate repo will be better. Why do we need these macOS only binary things?

The natural way to have software in NixOS is to install it from nixpkgs
The natural way to have software in macOS is to get .dmg from web and copy an app from it

In my opinion the real need to add a package for Darwin is when it does invasion into the sytem or is not available in binary form for macOS

matthewbauer · 2016-12-01T16:56:30Z

@gnidorah I guess the best answer I have is for completeness: we already have versions of these for Linux so we might as well have macOS versions as well. That being said the lack of a permanent versioned url make things very difficult.

LnL7 · 2016-12-01T18:00:13Z

@gnidorah I strongly disagree with that, for me there's no difference between an unfree derivation that targets linux or darwin. We also have other very large attribute sets that not everybody might care about (eg. the 10929 haskellPackages).

However I don't like adding packages that break at any point if a new version is released.

LnL7 · 2016-12-01T18:01:20Z

@matthewbauer can you create a pr for undmg

ghost · 2016-12-01T18:14:20Z

@matthewbauer @LnL7 got your points guys. But nix expressions for such packages look similar. Perhaps adding new ones may be somehow simplified? I.e. using single file or whatever.

for me there's no difference between an unfree derivation that targets linux or darwin

The difference is that on Linux you need to care about dependencies, but on Darwin they are bundled in case of .app programs, so the role of package manager is not very significant in that case

LnL7 · 2016-12-01T19:22:14Z

That's actually more of a discussion of free vs unfree derivations.

Most unfree linux packages are statically linked or have vendored dependencies,
and we have a derivation for MacVim.app that uses nix dependencies for example.

mpscholten · 2016-12-01T22:19:37Z

Regarding the versioning issues: We could build a script which updates the package hashes on a regulary schedule (e.g. every 30 minutes). This way, even when there is only the latest version of a package available for download, a simple nix-channel --update would fix the hashes. We could also just steal the hashes from the homebrew cask repository for most of the packages.

In general I really like this idea of being able to install all my software with nix on macOS.

Mic92 · 2016-12-03T14:41:28Z

You could also upload the packages to archive.org to get stable sources for updates.

LnL7 · 2016-12-04T12:18:13Z

I had no idea that https://archive.org also has software, I think that's a great solution if there are no licence issues with that.

Using a different source is not really a problem if we compare it with the latest official version at the point that it's merged in or if we automate the uploads with an update.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Darwin closed-source apps: init Steam, Spotify #20670

Darwin closed-source apps: init Steam, Spotify #20670

matthewbauer commented Nov 24, 2016 •

edited

Loading

mention-bot commented Nov 24, 2016

LnL7 Nov 24, 2016

matthewbauer Nov 24, 2016

LnL7 Nov 24, 2016

NeQuissimus Nov 24, 2016

LnL7 Nov 27, 2016

LnL7 Nov 24, 2016

matthewbauer Nov 24, 2016

FRidh Nov 24, 2016

LnL7 Nov 24, 2016

matthewbauer commented Nov 25, 2016

mpscholten commented Nov 25, 2016

ghost Dec 1, 2016 •

edited by ghost

Loading

matthewbauer Dec 1, 2016

ghost commented Dec 1, 2016 •

edited by ghost

Loading

matthewbauer commented Dec 1, 2016

LnL7 commented Dec 1, 2016

LnL7 commented Dec 1, 2016

ghost commented Dec 1, 2016 •

edited by ghost

Loading

LnL7 commented Dec 1, 2016

mpscholten commented Dec 1, 2016

Mic92 commented Dec 3, 2016 •

edited

Loading

LnL7 commented Dec 4, 2016

Darwin closed-source apps: init Steam, Spotify #20670

Darwin closed-source apps: init Steam, Spotify #20670

Conversation

matthewbauer commented Nov 24, 2016 • edited Loading

Motivation for this change

Things done

mention-bot commented Nov 24, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matthewbauer commented Nov 25, 2016

mpscholten commented Nov 25, 2016

ghost Dec 1, 2016 • edited by ghost Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Dec 1, 2016 • edited by ghost Loading

matthewbauer commented Dec 1, 2016

LnL7 commented Dec 1, 2016

LnL7 commented Dec 1, 2016

ghost commented Dec 1, 2016 • edited by ghost Loading

LnL7 commented Dec 1, 2016

mpscholten commented Dec 1, 2016

Mic92 commented Dec 3, 2016 • edited Loading

LnL7 commented Dec 4, 2016

matthewbauer commented Nov 24, 2016 •

edited

Loading

ghost Dec 1, 2016 •

edited by ghost

Loading

ghost commented Dec 1, 2016 •

edited by ghost

Loading

ghost commented Dec 1, 2016 •

edited by ghost

Loading

Mic92 commented Dec 3, 2016 •

edited

Loading