Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rambox: build from sources #20657

Closed
wants to merge 0 commits into from
Closed

rambox: build from sources #20657

wants to merge 0 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 23, 2016

Superseeded by #31137

@mention-bot
Copy link

@gnidorah, thanks for your PR! By analyzing the history of the files in this pull request, we identified @NeQuissimus to be a potential reviewer.

@Mic92
Copy link
Member

Mic92 commented Nov 24, 2016

looks like electron, wants to download something from github after building.
This breaks the build in sandbox mode:

https://gist.github.com/Mic92/70a6da1f44a590fb4c2b86e61bd40237

@Mic92
Copy link
Member

Mic92 commented Nov 24, 2016

The offending file looks like it could be rebuild in nix: https://github.com/electron-userland/electron-prebuilt/blob/master/install.js

@Mic92
Copy link
Member

Mic92 commented Nov 26, 2016

I do not know how this can be fixed. That's why I accepted the precompiled application in the first place.

@ghost ghost closed this Nov 27, 2016
@ghost ghost deleted the master2 branch December 27, 2016 08:12
@ghost ghost mentioned this pull request Apr 24, 2017
6 tasks
@ghost ghost restored the master2 branch July 5, 2017 04:58
@ghost ghost deleted the master2 branch July 5, 2017 05:00
@ghost ghost changed the title rambox: build from sources [WIP] rambox: build from sources Jul 5, 2017
@ghost ghost changed the title [WIP] rambox: build from sources . Nov 9, 2017
@ghost ghost restored the master2 branch November 9, 2017 11:13
@ghost ghost reopened this Nov 9, 2017
@ghost ghost closed this Nov 9, 2017
@ghost ghost deleted the master2 branch November 9, 2017 11:15
@ghost ghost changed the title . rambox: build from sources Nov 22, 2017
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants