-
-
Notifications
You must be signed in to change notification settings - Fork 925
Comparing changes
Open a pull request
base repository: jruby/jruby
base: 83c3ae5e90ba
head repository: jruby/jruby
compare: e52c4a86ea9d
- 13 commits
- 18 files changed
- 4 contributors
Commits on Nov 16, 2016
-
Configuration menu - View commit details
-
Copy full SHA for bfcec47 - Browse repository at this point
Copy the full SHA bfcec47View commit details
Commits on Nov 18, 2016
-
Configuration menu - View commit details
-
Copy full SHA for bc0d1d7 - Browse repository at this point
Copy the full SHA bc0d1d7View commit details
Commits on Nov 20, 2016
-
Fix marshaling Hash with default_proc set to nil
When we set `default_proc` to nil, we also have to update the internal flag. Fixes #4302
Configuration menu - View commit details
-
Copy full SHA for f36f607 - Browse repository at this point
Copy the full SHA f36f607View commit details
Commits on Nov 21, 2016
-
Merge pull request #4321 from kirs/fix-default-proc
Fix marshaling Hash with default_proc set to nil
Configuration menu - View commit details
-
Copy full SHA for 744a927 - Browse repository at this point
Copy the full SHA 744a927View commit details -
Fixes #4323. Usage of
#[]=
assignment in method argument broken.I had introduced a bad optimization during IR build phase. It assumed all Strings could be built out of order but I did not account for the fact that the same StrNode could be referenced by two instructions at the same time (since each occurrence will perform a dup). Note: It might look like I removed FrozenStrings from building out of order but the ordinary logic in buildWithOrder will end up creating the operand in place and not generating the copy since it is an ImmutableLiteral.
Configuration menu - View commit details
-
Copy full SHA for 89759e4 - Browse repository at this point
Copy the full SHA 89759e4View commit details
Commits on Nov 22, 2016
-
Merge pull request #4123 from etehtsea/gh-3799-syswrite-block
Fix IO#syswrite. Fixes #3799
Configuration menu - View commit details
-
Copy full SHA for 723f2da - Browse repository at this point
Copy the full SHA 723f2daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 043ea6f - Browse repository at this point
Copy the full SHA 043ea6fView commit details -
Merge pull request #4329 from etehtsea/gh-4104-resolv
Add missing PortUnreachable catch. Fixes #4104
Configuration menu - View commit details
-
Copy full SHA for 5a6d2e6 - Browse repository at this point
Copy the full SHA 5a6d2e6View commit details
Commits on Nov 23, 2016
-
With #4321 merged, we no longer have to skip that ruby spec.
Configuration menu - View commit details
-
Copy full SHA for 9c02ee0 - Browse repository at this point
Copy the full SHA 9c02ee0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36a172f - Browse repository at this point
Copy the full SHA 36a172fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fcfb94a - Browse repository at this point
Copy the full SHA fcfb94aView commit details -
Fixes #4253. Respond_to? returns private methods.
The basic fix is that in respond_to? we do not return true for protected methods. I made a few internal changes: 1. deprecated is RubyModule.isMethodBound(name, checkVisibility, checkRespondTo) 2. added RubyModule doesMethodRespondTo(name, checkVisibility) 3. changed what I think is appropriate consumers to call doesMethodRespondTo but in worst case it will call isMethodBound(name, checkVisibility) which is what it would have done anyways before this change. The only risk is that I converted something which wants isMethodBound but that would indicate some method further upstream calling a respond-to method and not really wanting respond to behavior. The things I changed we obvious in that they had respondto names. 4. I made a Helpers.doesMethodRespondTo so that RespondToCallsite and RubyModule can share the same logic.
Configuration menu - View commit details
-
Copy full SHA for d081169 - Browse repository at this point
Copy the full SHA d081169View commit details -
Configuration menu - View commit details
-
Copy full SHA for e52c4a8 - Browse repository at this point
Copy the full SHA e52c4a8View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 83c3ae5e90ba...e52c4a86ea9d