Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: 83c3ae5e90ba
Choose a base ref
...
head repository: jruby/jruby
compare: e52c4a86ea9d
Choose a head ref
  • 13 commits
  • 18 files changed
  • 4 contributors

Commits on Nov 16, 2016

  1. Bump jnr-enxio and add regression test

    Fixes #3799
    etehtsea committed Nov 16, 2016
    Copy the full SHA
    bfcec47 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2016

  1. Copy the full SHA
    bc0d1d7 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2016

  1. Fix marshaling Hash with default_proc set to nil

    When we set `default_proc` to nil, we also have to update the internal
    flag.
    
    Fixes
    #4302
    kirs committed Nov 20, 2016
    Copy the full SHA
    f36f607 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2016

  1. Merge pull request #4321 from kirs/fix-default-proc

    Fix marshaling Hash with default_proc set to nil
    enebo committed Nov 21, 2016
    Copy the full SHA
    744a927 View commit details
    Browse the repository at this point in the history
  2. Fixes #4323. Usage of #[]= assignment in method argument broken.

    I had introduced a bad optimization during IR build phase.  It assumed
    all Strings could be built out of order but I did not account for the
    fact that the same StrNode could be referenced by two instructions at
    the same time (since each occurrence will perform a dup).
    
    Note: It might look like I removed FrozenStrings from building out of
    order but the ordinary logic in buildWithOrder will end up creating
    the operand in place and not generating the copy since it is an
    ImmutableLiteral.
    enebo committed Nov 21, 2016
    Copy the full SHA
    89759e4 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2016

  1. Merge pull request #4123 from etehtsea/gh-3799-syswrite-block

    Fix IO#syswrite. Fixes #3799
    headius committed Nov 22, 2016
    Copy the full SHA
    723f2da View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    043ea6f View commit details
    Browse the repository at this point in the history
  3. Merge pull request #4329 from etehtsea/gh-4104-resolv

    Add missing PortUnreachable catch. Fixes #4104
    enebo committed Nov 22, 2016
    Copy the full SHA
    5a6d2e6 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2016

  1. Skip less specs

    With #4321 merged, we no longer have
    to skip that ruby spec.
    kirs committed Nov 23, 2016
    Copy the full SHA
    9c02ee0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #4331 from kirs/less-skip

    Skip less specs
    headius committed Nov 23, 2016
    Copy the full SHA
    36a172f View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    fcfb94a View commit details
    Browse the repository at this point in the history
  4. Fixes #4253. Respond_to? returns private methods.

    The basic fix is that in respond_to? we do not return true for protected
    methods.  I made a few internal changes:
    
    1. deprecated is RubyModule.isMethodBound(name, checkVisibility, checkRespondTo)
    2. added RubyModule doesMethodRespondTo(name, checkVisibility)
    3. changed what I think is appropriate consumers to call doesMethodRespondTo
       but in worst case it will call isMethodBound(name, checkVisibility) which
       is what it would have done anyways before this change.  The only risk is
       that I converted something which wants isMethodBound but that would indicate
       some method further upstream calling a respond-to method and not really
       wanting respond to behavior.  The things I changed we obvious in that they
       had respondto names.
    4. I made a Helpers.doesMethodRespondTo so that RespondToCallsite and
       RubyModule can share the same logic.
    enebo committed Nov 23, 2016
    Copy the full SHA
    d081169 View commit details
    Browse the repository at this point in the history
  5. Copy the full SHA
    e52c4a8 View commit details
    Browse the repository at this point in the history