New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GIMP on Darwin (use Quartz) #20658
GIMP on Darwin (use Quartz) #20658
Conversation
@matthewbauer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vcunat, @jwiegley and @cillianderoiste to be potential reviewers. |
Just tried this one on my darwin box, it did build nicely. When running gimp it does start, but it does not render any text. @matthewbauer is it working for you correctly? Did you have to apply any tweaks to make fonts work with the quartz backend? |
@johbo Okay, this should be fixable. When you run gimp, are you getting something like We may need to have to fix the OS X version of fontconfig for this to work correctly. |
Yes, indeed, I am getting exactly this error. |
Is this WIP then? |
@matthewbauer did the fonts actually work in your case? I'd love to get this working, but seems I would need a hint to proceed. |
No I don't think so. I would try getting rid of the fontconfig input and
hoping it finds coretext.
…On Thu, Dec 22, 2016 at 6:49 PM Johannes Bornhold ***@***.***> wrote:
@matthewbauer <https://github.com/matthewbauer> did the fonts actually
work in your case? I'd love to get this working, but seems I would need a
hint to proceed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#20658 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABKXOIPYf64uNQWWvSx5GbMV4MY_HIcks5rKxqcgaJpZM4K60MV>
.
|
Got some progress, thanks for the hint. I've added CoreText in a few places until the configure scripts did detect it. I've changed cairo and pango currently, not yet sure though if both changes are needed. |
@matthewbauer I got the font problem sorted and tested your change on top of it, now I got to see the fonts. I've pushed the testing code into my fork at https://github.com/johbo/nixpkgs/tree/test-gimp-darwin in case you are interested. |
@johbo Awesome! You should open a new pull request so it can be more visible. |
dbe8e64
to
e965885
Compare
Okay, this should be mergeable but only after #21382 is merged. |
|
||
installPhase = '' | ||
mkdir -p $out/bin | ||
sed "s,@PATH@,$out/share,g" < gtk-mac-bundler.in > $out/bin/gtk-mac-bundler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can replace variables like that with substitute, perhaps that's a little bit nicer.
substitute gtk-mac-bundler.in $out/bin/gtk-mac-bundler \
--subst-var-by PATH $out/share
0103c39
to
27c68d9
Compare
27c68d9
to
5a637ae
Compare
This and your other PRs need |
I'm seeing issues when executing the binary https://gist.github.com/LnL7/5c22cf16316b2c4a3f8e5720a8959f82. |
5a637ae
to
21143cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my bad, I didn't realise this needed DYLD_FRAMEWORK_PATH
Motivation for this change
This adds some tricks to get GIMP to build on my Darwin machine.
GTK2 has a quartz backend that we haven't been using. I'm not sure why it's not being used but it should probably be enabled by default. While GIMP may work without GTK +quartz, I XQuartz is really annoying to use and not my preference.
For some reason PyGTK and GTK2 +quartz don't seem to work well. It's really confusing because it looks like at some point the MacPorts project had everything working well but the compiler seems to treat objc headers like they are c header. See https://trac.macports.org/ticket/37713.
Note: This does not produce an "Application" yet on Darwin. It should be possible but our GIMP release does not seem to produce the correct "gtk-mac-bundler" .bundle file (see the gimp/build/osx/gimp-2.8.bundle file).
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)