Android targets [WIP] #3572

ysbaddaden · 2016-11-23T18:04:08Z

Basic support for building Crystal apps targeting Android.

Glue for ANativeActivity and other Android NDK API (ANativeWindow, event listeners/dispatchers, JNI, ...) to build Android aware applications will eventually come as an external shard.

refi64 · 2016-11-23T18:07:09Z

I'm just going to now call you the "porting wizard". :)

ysbaddaden · 2016-11-23T18:09:20Z

src/regex/lib_pcre.cr

@@ -23,5 +23,7 @@ lib LibPCRE
  $pcre_free : Free
 end

-LibPCRE.pcre_malloc = ->GC.malloc(LibC::SizeT)
-LibPCRE.pcre_free = ->GC.free(Void*)
+{% unless flag?(:without_pcre) %}


These two lines are the ones responsible for always linking apps against PCRE into the built binary, whatever if the application uses PCRE or not. It may be interesting to have a special macro for lib that would be called whenever that lib is actually used @asterite

I disable it because I don't need it (yet) and building libraries for the NDK is a pain, so I settled for iconv, gc and libevent for the time being.

The macro idea is good, we sometimes need to run code but only if the lib is actually used. The "problem" is that the compiler finds out if a lib is used when a lib fun is invoked, and at that point the macro would need to be expanded and typed... and then the codegen should put that code right where the macro definition exists. I'll try to think how to implement this, maybe it's not that hard. I'm thinking about something like macro initialize, but another (better) name should be good too.

ysbaddaden · 2016-11-23T18:09:58Z

src/signal.cr

@@ -126,4 +126,6 @@ fun __crystal_sigfault_handler(sig : LibC::Int, addr : Void*)
  LibC._exit sig
 end

-LibExt.setup_sigfault_handler
+{% unless flag?(:without_sigfault_handler) %}


Same here: I chilled to build libcrystal.a thought it should be relatively easy.

ysbaddaden · 2016-11-23T18:11:50Z

src/main.cr

-redefine_main do |main|
-  {{main}}
-end
+{% unless flag?(:android) || flag?(:without_main) %}


I also added the without_main flag because it may be useful in some contexts. I.e., building libraries.

RX14 · 2016-11-23T18:57:51Z

@kirbyfan64 Julien Portalier

mverzilli · 2016-11-23T19:00:34Z

@kirbyfan64 Julien Portalier

Well that explains it all :O

faustinoaq · 2017-09-14T14:07:10Z

to build Android aware applications will eventually come as an external shard.

I think these shards are relevant here:

Sophrinix · 2017-10-10T20:42:00Z

This appears to have stalled out. What is needed to get this QA'd and merged? There is a lot of value here. It also seems to me that this would also help in the effort to get crystal on iOS as well.

ysbaddaden · 2017-10-11T11:12:07Z

what is needed to get this QA'd and merged?

Running (and fixing) the std_spec on Android for the current target.
Generating bindings (and testing) other android targets (e.g. arm64).

ysbaddaden · 2017-10-11T11:14:08Z

iOS is quite different, but basically that doesn't change much than adding a target to Crystal. Except that iOS requires special fixes for the ARM ABI.

Use a single name (`errno`) instead of using the target specific naming (`__error`, `__errno`, `__errno_location`). With support for Android NDK.

asterite · 2018-04-27T17:34:13Z

@ysbaddaden Can we close this, but maybe keep it as a branch somewhere until it can be merged? Just so that we don't keep stalled PRs (I'd like to do a cleanup).

ysbaddaden · 2018-04-29T00:01:22Z

Closing for the time being. Regenerating C bindings is boring, and some additions such as VaList made it harder :(

nightblade9 · 2019-06-12T03:59:16Z

Is this still in progress or is it abandoned? I see that the incoming fork has commits as recent as March 2019 (less than three months ago).

Mhowser · 2020-09-11T22:35:01Z

Hello, has there been any progress here?

bcardiff · 2020-09-11T22:52:14Z

Nobody is working in android precisely. @jhass has done some progress to add arm64 CI to avoid going backwards in the progress to that. Other than that, no.

Mhowser · 2020-09-11T22:59:26Z

Thanks for the update. Is there anything we can do to accelerate the process?

jhass · 2020-09-11T23:40:10Z

Sure, you can contribute :) pull requests welcome!

phykos · 2020-09-12T13:31:35Z

I'm kinda new to LLVM and stuff, but doesn't it's bitcode get compiled on Android too?

I mean, why can't bitcode produced by the Crystal compiler run on Android?

jhass · 2020-09-12T17:52:41Z

Producing bytecode for the usual Android architectures is not the problem, the task is ABI compatibility and porting the standard library.

phykos · 2020-09-12T18:05:49Z

Damn right

The hardest part of porting the stdlib will probably be the LLVM module

jhass · 2020-09-13T07:57:38Z

What LLVM module?

phykos · 2020-09-13T14:12:56Z

What LLVM module?

The LLVM module available at the top-level

jhass · 2020-09-13T15:58:47Z

That should just work when the ABI is implemented properly.

ysbaddaden commented Nov 23, 2016

View reviewed changes

ysbaddaden force-pushed the support-android branch from f3d3e45 to 6f6a404 Compare March 31, 2017 13:52

bew mentioned this pull request Dec 12, 2017

Add some code only if the given lib is used #5379

Open

ysbaddaden added 6 commits April 14, 2018 15:08

Add target: arm-linux-androideabi

fa3b09c

Android doesn't support Thread Local Storage

5422ed8

Android uses ANativeActivity_onCreate as the main entry

376f4f6

Refactor LibC.errno naming

6b78f24

Use a single name (`errno`) instead of using the target specific naming (`__error`, `__errno`, `__errno_location`). With support for Android NDK.

TEMPROARY FIX: flags to disable sigault_handle + PCRE malloc/free

6846fe1

Fix: DWARF reader fails on android. Disable for now.

803eaf8

ysbaddaden force-pushed the support-android branch from 6f6a404 to 803eaf8 Compare April 14, 2018 13:26

ysbaddaden closed this Apr 29, 2018

ravener mentioned this pull request Mar 1, 2019

Package request: Crystal termux/termux-packages#3401

Closed

HertzDevil mentioned this pull request Feb 11, 2023

AArch64 Android support #13065

Merged

HertzDevil added the platform:android label Mar 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android targets [WIP] #3572

Android targets [WIP] #3572

ysbaddaden commented Nov 23, 2016 •

edited

refi64 commented Nov 23, 2016

ysbaddaden Nov 23, 2016

asterite Nov 23, 2016

ysbaddaden Nov 23, 2016

ysbaddaden Nov 23, 2016

RX14 commented Nov 23, 2016

mverzilli commented Nov 23, 2016

faustinoaq commented Sep 14, 2017

Sophrinix commented Oct 10, 2017

ysbaddaden commented Oct 11, 2017

ysbaddaden commented Oct 11, 2017

asterite commented Apr 27, 2018

ysbaddaden commented Apr 29, 2018

nightblade9 commented Jun 12, 2019

Mhowser commented Sep 11, 2020

bcardiff commented Sep 11, 2020

Mhowser commented Sep 11, 2020

jhass commented Sep 11, 2020

phykos commented Sep 12, 2020 •

edited

jhass commented Sep 12, 2020

phykos commented Sep 12, 2020

jhass commented Sep 13, 2020

phykos commented Sep 13, 2020

jhass commented Sep 13, 2020

Android targets [WIP] #3572

Android targets [WIP] #3572

Conversation

ysbaddaden commented Nov 23, 2016 • edited

refi64 commented Nov 23, 2016

ysbaddaden Nov 23, 2016

Choose a reason for hiding this comment

asterite Nov 23, 2016

Choose a reason for hiding this comment

ysbaddaden Nov 23, 2016

Choose a reason for hiding this comment

ysbaddaden Nov 23, 2016

Choose a reason for hiding this comment

RX14 commented Nov 23, 2016

mverzilli commented Nov 23, 2016

faustinoaq commented Sep 14, 2017

Sophrinix commented Oct 10, 2017

ysbaddaden commented Oct 11, 2017

ysbaddaden commented Oct 11, 2017

asterite commented Apr 27, 2018

ysbaddaden commented Apr 29, 2018

nightblade9 commented Jun 12, 2019

Mhowser commented Sep 11, 2020

bcardiff commented Sep 11, 2020

Mhowser commented Sep 11, 2020

jhass commented Sep 11, 2020

phykos commented Sep 12, 2020 • edited

jhass commented Sep 12, 2020

phykos commented Sep 12, 2020

jhass commented Sep 13, 2020

phykos commented Sep 13, 2020

jhass commented Sep 13, 2020

ysbaddaden commented Nov 23, 2016 •

edited

phykos commented Sep 12, 2020 •

edited