Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

btrbk: 0.22.2 -> 0.24.0 #20978

Closed
wants to merge 1 commit into from
Closed

btrbk: 0.22.2 -> 0.24.0 #20978

wants to merge 1 commit into from

Conversation

kampka
Copy link
Contributor

@kampka kampka commented Dec 7, 2016 •
edited

Motivation for this change

Upgrades btrbk to the latest upstream version.
This new version requires config migrations due to incompatible changes.
Does a package need to handle this somehow?

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@kampka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @the-kenny and @dezgeg to be potential reviewers.

@the-kenny
Copy link
Contributor

Thanks for the heads-up! I've got some personal backup services that depend on it, but I'm fine with modifying them. Grepping for btrbk doesn't yield any services depending on it.

@kampka
Copy link
Contributor Author

kampka commented Dec 8, 2016

@the-kenny right, I also didn't find any service, so I created my own.
It is kind of opinionated at the moment, but I could be persuaded to improve on it an send a pull request.

@kampka
Copy link
Contributor Author

kampka commented Dec 10, 2016

I added openssh to the path in order to get the ssh integration working.
Since the change seems trivial, I squashed the commit ontop of the version bump.

@the-kenny
Copy link
Contributor

the-kenny commented Dec 10, 2016 •
edited

Merged as a1d9d7e (PR should auto-close soonish)

@the-kenny the-kenny closed this Dec 10, 2016
@kampka kampka deleted the btrbk branch December 10, 2016 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kampka @mention-bot @the-kenny @pSub